Repository navigation
feat(analysis): ask guests to sign in on the Lichess tab - #360
Merged
Merged
Conversation
…hess games yet" The analysis game list's Lichess tab lists the signed-in visitor's recent Lichess games. A guest who opened it was told "No Lichess games yet", which is wrong (the site just can't see them) and gave no way forward. It now says that signing in with Lichess shows their recent games here to analyze with Maia, with a Sign in with Lichess button (source analysis_lichess_tab). Signed-in visitors see the list as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #359 (it uses
connectLichess(source)). Merge #359 first; this PR then retargets to main.What
The analysis page's game list has a Lichess tab with the visitor's recent Lichess games. A guest who opened it was told "No Lichess games yet". That's wrong (the site can't see their games until they sign in), and it gave them no way forward. It's also one of the clearest reasons to sign in: analysis is the site's second most-used feature (22–26% of sessions from the home page).
Change
For a guest, the tab now says "Sign in with Lichess to see your recent Lichess games here and analyze them with Maia." and has a Sign in with Lichess button. The button records
source: analysis_lichess_tabwith #359's events, so its sign-ins can be counted. Signed-in visitors see the list as before.The wording only promises what the code does: after sign-in,
AnalysisListContextstreams the user's games from Lichess into this tab. The backend keeps a guest's rating and games when they sign in with Lichess for the first time; this PR doesn't mention that.Checked
Production build, desktop 1440×900 and phone 390×844 (
loadperf/tools/lichess-tab.mjs, account faked):auth/lichess_login?redirect_url=…/analysis/7WCFYt0R/1.npm test(265), tsc and eslint pass.🤖 Generated with Claude Code