Repository navigation
Stub out usb/physical_macos.c on non-Apple systems - #567
Merged
Merged
Conversation
This file gets built on all systems, but will only successfully build on Apple systems. Rather than hack the makefile to detect Apple systems and exclude only this file, simply remove the entire file contents on non-Apple systems so it builds successfully. Without this I'm unable to build libcemucore.a (and thus also the SDL GUI) on Linux
Member
|
Oops, we really ought to add standalone core and SDL CI build jobs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file gets built on all systems, but will only successfully build on Apple systems. Rather than hack the makefile to detect Apple systems and exclude only this file, simply remove the entire file contents on non-Apple systems so it builds successfully.
Without this I'm unable to build libcemucore.a (and thus also the SDL GUI) on Linux, with it I can successfully build the SDL GUI.