Skip to content

[FIX] Fix zero timestamps for GXF/MXF ancillary captions #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfsmp3 merged 1 commit into from
Oct 18, 2026
Merged

[FIX] Fix zero timestamps for GXF/MXF ancillary captions #2390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/lib_ccx/general_loop.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,12 +987,15 @@ int process_data(struct encoder_ctx *enc_ctx, struct lib_cc_decode *dec_ctx, str
// CCX_RAW_TYPE contains cc_data triplets (cc_type + 2 data bytes each)
// Used by MXF and GXF demuxers

// Initialize timing if not set (use caption PTS as reference)
if (dec_ctx->timing->pts_set == 0 && data_node->pts != CCX_NOPTS)
// Use the first caption PTS as the timing reference. The caller has
// already passed it to set_current_pts() (in 90 kHz units), which sets
// pts_set to 1; with no video frames set_fts() never reaches MinPtsSet
// on its own, so check for that rather than for pts_set == 0.
if (dec_ctx->timing->pts_set != 2 && data_node->pts != CCX_NOPTS)
{
dec_ctx->timing->min_pts = data_node->pts;
dec_ctx->timing->min_pts = dec_ctx->timing->current_pts;
dec_ctx->timing->pts_set = 2; // MinPtsSet
dec_ctx->timing->sync_pts = data_node->pts;
dec_ctx->timing->sync_pts = dec_ctx->timing->current_pts;
set_fts(dec_ctx->timing);
}

Expand Down
Loading