Repository navigation
[FIX] Accept the remaining legacy option spellings - #2383
Merged
Merged
Conversation
The C parser in v0.94 accepted short and underscore spellings such as -nofc, -bi, -gt, -haup, -ocr_mode and --gui_mode_reports. The Rust parser rejects 46 of them with "Unknown Argument", so old scripts and frontends stop working. #2368 covered nine; this covers the rest that still have an equivalent option. Each spelling becomes a hidden clap alias on the option with the same behaviour, so --help is unchanged and option values are still skipped by normalize_legacy_args. -ntm/--no-timestamp-map get a hidden no-op flag: v0.94 wrote the X-TIMESTAMP-MAP header by default and this turned it off, but the header is now off unless --timestamp-map is given. The sharing and translation options (-enable-sharing, -sharing-url, -sharing-debug, -translate, -translate-auth) stay rejected because that feature no longer exists. -curlposturl already works in builds with libcurl, as in v0.94.
cfsmp3
force-pushed
the
fix/remaining-legacy-options
branch
from
October 17, 2026 23:39
8740344 to
4b756e3
Compare
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
Reason for this PR:
Sanity check:
Repro instructions:
On master, any of these fails with
Unknown Argument(exit 7) on any input, e.g.ccextractor input.ts -nofc:-bi -nobi --nobufferinput -ff -bs -nofc --nofontcolor --nohtmlescape -nots --notypesetting -ntm --no-timestamp-map -nocodec -nospupngocr --transcript --timedtranscript -ve -gt -nogt --nogoptime -fp --norollup -key --gui_mode_reports --no_progress_bar -sbs -caf -pn -dc -scr -nolevdist -anvid -investigate_packets -nosync -haup -poc -tcppassword -tcpdesc -tickertape -ocr_mode -sub_color -min_sub_duration -detect_italics -conf_thresh -whiteness_thresh -lum_threshFollow-up to #2368. The v0.94 C parser accepted these spellings; the Rust parser rejects them, so old scripts and frontends break. #2368 covered nine; this covers the remaining 46 that still have an equivalent option.
params.candparser.rs), so--helpis unchanged andnormalize_legacy_argsstill skips option values.-ntm/--no-timestamp-map: v0.94 wrote WebVTT'sX-TIMESTAMP-MAPheader by default and this turned it off. The header is now off unless--timestamp-mapis given, so these are accepted as a hidden no-op (and conflict with--timestamp-map).-pnneeds a value now; v0.94 also allowed a bare-pnfor autodetect.-enable-sharing,-sharing-url,-sharing-debug,-translate,-translate-auth— the sharing/translation feature no longer exists, so accepting them would silently do nothing.-curlposturlalready works in libcurl builds, as in v0.94.Verified:
Argsas its modern spelling; the removed-feature spellings stay rejected; a legacy-looking option value is not rewritten. They fail without the change.--helpis byte-identical to master.-nofc, which master rejects and which now matches--no-fontcolor.