Skip to content

Remove unused AllowUnsafeBlocks from Cli project - #105

Merged
Seramis merged 1 commit into
ByteAether:mainfrom
Seramis:chore/cli-remove-unsafe-blocks
Oct 10, 2026
Merged

Seramis merged 1 commit into
ByteAether:mainfrom
Seramis:chore/cli-remove-unsafe-blocks

Conversation

@Seramis

@Seramis Seramis commented Oct 10, 2026

Copy link
Copy Markdown
Member

Description

No unsafe code exists in ByteAether.Ulid.Cli, so the flag only widens the compiler's safety checks for no benefit.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Other (please specify): .csproj change.

Checklist

  • The PR is submitted to the correct branch (main).
  • My code follows the project's coding style. (.editorconfig)
  • I have commented my code, particularly in hard-to-understand areas and public interfaces.
  • I have added or updated tests for the changes I made.
  • All new and existing tests passed.
  • I have updated the documentation where applicable.

@Seramis Seramis self-assigned this Oct 10, 2026
@Seramis Seramis added the pkg:Cli ByteAether.Ulid.Cli label Oct 10, 2026
No unsafe code exists in ByteAether.Ulid.Cli, so the flag only
widens the compiler's safety checks for no benefit.
@Seramis
Seramis force-pushed the chore/cli-remove-unsafe-blocks branch from d3ac812 to bf88bce Compare October 10, 2026 14:11
@Seramis
Seramis merged commit 23865ac into ByteAether:main Oct 10, 2026
5 checks passed
@Seramis
Seramis deleted the chore/cli-remove-unsafe-blocks branch October 10, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:Cli ByteAether.Ulid.Cli

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant