Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
Static Analysis / Prettiercheck (pnpm lint:prettier, i.e.prettier --check .) fails ondevelopbecause several files are not formatted.What changed
infra/*.yaml, and two files in shared-components).Left out on purpose
RoomListHeaderViewModel.tsandRoomListHeaderView.tsxare not included here. They are also modified in #23, which formats them, so including them in this PR would cause a merge conflict.Verified
pnpm lint:prettiernow reports only those two files.git diff -wagainstdevelopshows 28 files with changes beyond whitespace. All of them are line joins or splits and trailing commas.Notes
Other CI checks that already fail on
develop(TypeScript, ESLint, etc.) are out of scope and tracked in separate cards.Done when:
Static Analysis / Prettieris green (after #23 is merged).