Repository navigation
Log the real output folder when splitting with ffmpeg - #595
Merged
Breakthrough merged 2 commits intoOct 31, 2026
Merged
Breakthrough merged 2 commits into
Breakthrough merged 2 commits into
Conversation
MuhammadBilalKhan267
approved these changes
Oct 27, 2026
Breakthrough
approved these changes
Oct 31, 2026
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @Breakthrough I have noticed when
split-videoruns with-o, theOutput folder:log line prints the filename template instead of the folder, becausesplit_video_ffmpegpasses the wrong variable to the logger. For example,-o D:\out split-videoused to logOutput folder: $VIDEO_NAME-Scene-$SCENE_NUMBER.mp4and now logsOutput folder: D:\out. Only the message was wrong, the clips always went to the right folder. The existing ffmpeg split test now also checks this log line.