Skip to content

Check the whole vault wiring before deposits open #326

Closed

Description

@hpmaxi

Priority

Medium

User story / Problem statement

As an adopter deploying on my own, I want the vault closed while its wiring is wrong. finish_setup checks the bindings, the token's manager role, the share supply, the allowlist and the freeze. It does not check that the asset has the share token's decimals, that the asset, token, oracle and vault are four different addresses, that the oracle answers the feed's views, or that a custodian is set. set_custodian and a timelocked Custodian change accept the vault's own address.

Expected outcome

finish_setup refuses with SetupIncomplete until each of these holds, and health() reports each one. Every path that sets the custodian refuses the vault's address with a new error.

Acceptance criteria

  • One setup test per new check: each miswiring is refused with SetupIncomplete, and its health() field is false
  • A custodian equal to the vault is refused everywhere it can be set
  • The harness deploy checks the new fields and passes on a local network
  • The kit spec's Health table and runbook list the new checks

Alternatives considered

Requiring a valid price before setup finishes. A new feed has no report yet, so the check only asks that the oracle answers.

Activity

  1. luchobonatti commented on Oct 27, 2026

    @luchobonatti
    Member

    Done in #275, merged into feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions