Skip to content

COMP: Read DREAM3D_ENABLE_OOC for the out-of-core store tests - #1995

Open
imikejackson wants to merge 1 commit into
BlueQuartzSoftware:developfrom
imikejackson:topic/dream3d-enable-ooc-option
Open

imikejackson wants to merge 1 commit into
BlueQuartzSoftware:developfrom
imikejackson:topic/dream3d-enable-ooc-option

Conversation

@imikejackson

Copy link
Copy Markdown
Contributor

Summary

The SimplnxCore, OrientationAnalysis and NXImageProcessing test lists now read the DREAM3D-NX build option DREAM3D_ENABLE_OOC to register their OocStoreContracts tests. DREAM3D-NX renamed the option from DREAM3DNX_ENABLE_OOC, so that all of its build options start with DREAM3D_. 4 files changed, +4 / −4 lines.

Companion pull request: BlueQuartzSoftware/DREAM3DNX#1255 renames the option in DREAM3D-NX. It also sets the old name until simplnx reads the new one, so #1255 can merge before this pull request. Merge #1255 first or at the same time: a DREAM3D-NX develop without #1255 does not set DREAM3D_ENABLE_OOC, and its out-of-core builds would then not register these three tests.

1. Out-of-core store test registration

  • src/Plugins/SimplnxCore/test/CMakeLists.txt — SimplnxCoreOocStoreContracts
  • src/Plugins/OrientationAnalysis/test/CMakeLists.txt — OrientationAnalysisOocStoreContracts
  • src/Plugins/NXImageProcessing/test/CMakeLists.txt — ImageProcessingOocStoreContracts

Each test list registers its contract test when DREAM3D_ENABLE_OOC is ON. A simplnx-only build does not set the option, so it registers none of these tests, as before.

2. Developer guidance

  • AGENTS.md — out-of-core tests need a DREAM3D-NX build with DREAM3D_ENABLE_OOC=ON.

Test plan

  • DREAM3D-NX out-of-core build with BlueQuartzSoftware/DREAM3DNX#1255 and this branch (macOS): ctest -N -L ooc -LE benchmark lists 1055 tests, the same as before the change, including SimplnxCoreOocStoreContracts, ImageProcessingOocStoreContracts and OrientationAnalysisOocStoreContracts.
  • DREAM3D-NX in-core build: none of the three contract tests is registered.
  • CI passes.

Related Issue

  • This PR has no related issue

DREAM3D-NX now names its out-of-core build option DREAM3D_ENABLE_OOC, like
its other build options. The SimplnxCore, OrientationAnalysis and
NXImageProcessing test lists register their OocStoreContracts tests when
that option is ON.

Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
@imikejackson imikejackson self-assigned this Nov 19, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant