Repository navigation
COMP: Read DREAM3D_ENABLE_OOC for the out-of-core store tests - #1995
Open
imikejackson wants to merge 1 commit into
Open
imikejackson wants to merge 1 commit into
imikejackson wants to merge 1 commit into
Conversation
DREAM3D-NX now names its out-of-core build option DREAM3D_ENABLE_OOC, like its other build options. The SimplnxCore, OrientationAnalysis and NXImageProcessing test lists register their OocStoreContracts tests when that option is ON. Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The SimplnxCore, OrientationAnalysis and NXImageProcessing test lists now read the DREAM3D-NX build option
DREAM3D_ENABLE_OOCto register theirOocStoreContractstests. DREAM3D-NX renamed the option fromDREAM3DNX_ENABLE_OOC, so that all of its build options start withDREAM3D_. 4 files changed, +4 / −4 lines.Companion pull request: BlueQuartzSoftware/DREAM3DNX#1255 renames the option in DREAM3D-NX. It also sets the old name until simplnx reads the new one, so #1255 can merge before this pull request. Merge #1255 first or at the same time: a DREAM3D-NX
developwithout #1255 does not setDREAM3D_ENABLE_OOC, and its out-of-core builds would then not register these three tests.1. Out-of-core store test registration
src/Plugins/SimplnxCore/test/CMakeLists.txt—SimplnxCoreOocStoreContractssrc/Plugins/OrientationAnalysis/test/CMakeLists.txt—OrientationAnalysisOocStoreContractssrc/Plugins/NXImageProcessing/test/CMakeLists.txt—ImageProcessingOocStoreContractsEach test list registers its contract test when
DREAM3D_ENABLE_OOCis ON. A simplnx-only build does not set the option, so it registers none of these tests, as before.2. Developer guidance
AGENTS.md— out-of-core tests need a DREAM3D-NX build withDREAM3D_ENABLE_OOC=ON.Test plan
ctest -N -L ooc -LE benchmarklists 1055 tests, the same as before the change, includingSimplnxCoreOocStoreContracts,ImageProcessingOocStoreContractsandOrientationAnalysisOocStoreContracts.Related Issue