Repository navigation
BUG: Correct filter results, pipeline copies, and output checks - #1974
Merged
imikejackson merged 20 commits intoNov 19, 2026
Merged
imikejackson merged 20 commits into
imikejackson merged 20 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
joeykleingers
requested changes
Nov 13, 2026
Contributor
Author
Review feedback checklistAll nine items from Joey Kleingers’s review, with the original priorities. High
Medium
Nits
All fixes are included in |
Contributor
There was a problem hiding this comment.
The summary of my review of 2026-11-13 is covered by the review feedback checklist.
jmarquisbq
force-pushed
the
fix/small-data-corrections
branch
from
November 16, 2026 19:57
af5ed3a to
72beb73
Compare
jmarquisbq
requested review from
joeykleingers
and removed request for
joeykleingers
November 16, 2026 21:05
joeykleingers
approved these changes
Nov 18, 2026
joeykleingers
left a comment
Contributor
There was a problem hiding this comment.
Approved. I fixed the last five review nits in a7f2cd2: the Loop Until Gone help text now says that a stalled loop returns an error, the -15001/-15003 preflight codes and the isDisabled key are named constants, NumberToStringFilterParameterConverter::convert has Doxygen, the Boolean conversion test uses SIMPLNX_RESULT_REQUIRE_VALID, and the V&V summary mentions error -15002.
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Move each feature tuple to its remapped ID through complete cycles. Test scalar and component associations with resident and disk-backed stores. Preserve feature zero and unused trailing feature rows. Fixes BlueQuartzSoftware#1785 Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Keep legacy numbers accurate in floating-point and integer arrays. Apply numeric truth to Boolean replacement and matching values. Test precision limits, both algorithms and disk-backed Boolean stores. Fixes BlueQuartzSoftware#1944 Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Include the half-subdivision offset used by sample placement. Preserve sample coordinates and check distances against geometric values. Fixes BlueQuartzSoftware#1797 Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Return an error when Loop Until Gone cannot replace any remaining failing cell. Preserve tuples copied before the stalled pass. Cover no donors, repeated propagation, partial progress and cancellation with resident and disk-backed arrays. Closes BlueQuartzSoftware#1806 Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Keep disabled flags and filter comments through node copies and pipeline value operations. Restore Boolean flags for placeholders while retaining their raw JSON and prior malformed-flag fallback. Cover copying, saving, extraction and replay with a disabled reader. Closes BlueQuartzSoftware#1807 Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Replace the pending checkpoint with the verified seven-case results. Keep the historical sign-offs and limit the storage claim to metadata and replay behavior. Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Return invalid Results when filesystem status queries fail. Preserve missing-path and concurrent-directory-creation behavior. Include the full operating-system message when directory creation fails. Add POSIX permission regressions and explicit platform skips. Refs BlueQuartzSoftware#1856 Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Require Loop Until Gone to use the selected geometry's Cell Data. Declare only the numeric arrays that execution can modify. Check both external input placements, single-pass behavior, and geometries with no Cell Attribute Matrix. Refs BlueQuartzSoftware#1806 Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Use a UUID for each fixture directory. Create the directory before using it and remove only the exact path the fixture owns. Refs BlueQuartzSoftware#1856 Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Record the stalled-loop deviation in the report summary. Point readers to the PR test plan and retain the dated Write DREAM3D regression results without workflow wording. Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
State that Pipeline copies share their child nodes and that move operations transfer the existing collection. Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Check the public cancellation result before execution and after a pass. Retain the progress and tuple assertions. Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Read the Boolean from the guarded lookup and keep the raw fallback JSON. Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Preserve nonzero fractions in the shared converter while retaining the existing integer and text fallbacks. Use the shared path from ConditionalSetValue and add a core test. Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Exercise the core utility with scalar IDs and component tuples. Verify feature zero, a long cycle, and unchanged trailing rows. Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Document the public cancellation error and the algorithm checkpoint separately. Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Write exact decimal values at Float32 rounding ties. Test legacy comparison and replacement at ties and adjacent values through the public filter. Document Boolean replacements and use the shared disk-backing assertion. Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Keep path diagnostics in UTF-8 and report a follow-up inspection error when directory creation reports no error. Let threshold loops use an alternate path to the same comparison array in Cell Data. Clarify the native pipeline replay guarantee and identify the tested revision in the writer verification report. Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
Signed-off-by: Jessica Marquis <jessica.marquis@bluequartz.net>
- The Loop Until Gone help text says that a stalled loop returns an error, as the filter page and the V&V report do. - Name the -15001 and -15003 preflight error codes. - PlaceholderFilter reads the disabled flag through AbstractPipelineNode::k_IsDisabledKey instead of a second literal. - Document NumberToStringFilterParameterConverter::convert. - The Boolean conversion test asserts with SIMPLNX_RESULT_REQUIRE_VALID. - The V&V summary says that a stalled loop returns error -15002.
imikejackson
force-pushed
the
fix/small-data-corrections
branch
from
November 18, 2026 21:22
a7f2cd2 to
89de3e0
Compare
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep feature attributes aligned with randomized IDs, preserve legacy numeric values, and measure edge samples from the starting endpoint. Preserve pipeline metadata, stop stalled threshold replacement loops, and return errors when output path inspection fails. 38 files changed, +2171 / −111 lines.
The companion SimplnxOoc #42 updates a test for an interface already on
develop. The two PRs can merge in either order.1. Filter results and termination
src/simplnx/Utilities/ClusteringUtilities.cppmoves each feature tuple to its mapped ID through complete permutation cycles. Feature zero stays fixed.src/simplnx/Parameters/StringParameter.cpppreserves the value of floating-point legacy JSON parameters when it converts them to text. Integer inputs use the existing integer conversion.src/simplnx/Utilities/StringInterpretationUtilities.hpptreats complete nonzero fractional text as true in the shared Boolean converter. ConditionalSetValue uses that converter for both execution paths.src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/PointSampleEdgeGeometry.cppincludes the half-subdivision offset in each distance from the starting endpoint.src/Plugins/SimplnxCore/src/SimplnxCore/Filters/ReplaceElementAttributesWithNeighborValuesFilter.cpprequires a comparison array in the geometry's Cell Attribute Matrix in loop mode. A stalled pass returns-15002. The public filter reports cancellation as-1. Tuples copied before either result remain changed.2. Pipeline copies and output checks
src/simplnx/Pipeline/Pipeline.cpppreserves disabled state through pipeline copies and value operations. Filter and placeholder copies retain metadata used by Write DREAM3D-NX File and the extracted pipeline.src/simplnx/Utilities/FilterUtilities.cppandsrc/simplnx/Utilities/FileUtilities.cppreturn errors-4090and-4092when output path inspection fails. Directory creation error-4010includes the operating system error code and message.Test Plan
The builds used simplnx
72beb73abondevelop8cad1e818with EbsdLib 3.1.4. The paired out-of-core build used SimplnxOoc8bfd2ee7and DREAM3D-NX8e6d7403.Scoped clang-tidy returned a nonzero result. Only assertion-macro diagnostics remained on lines changed by the review fixes.
Related Issue
Closes #1785
Closes #1944
Closes #1797
Closes #1806
Closes #1807
Closes #1856
Related to #1878 (PointSampleEdgeGeometryFilter item 4)
Related to #1879 (RandomizeFeatureIdsFilter item 1)