Skip to content

Bump smplx-std dep to 0.2.0 - #67

Merged
Hrom131 merged 5 commits into
devfrom
feat/bump
Nov 5, 2026
Merged

Hrom131 merged 5 commits into
devfrom
feat/bump

Conversation

@ikripaka

@ikripaka ikripaka commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator
  • This PR suggests a bug fix and I've added the necessary tests.
  • This PR introduces a new feature and I've discussed the update in an Issue or with the team.
  • This PR is just a minor change like a typo fix.

Migrate simplicity-std to the 0.2.0 simplex version.
Format contracts with the simplex formatter, add CI check.
According to this issue: BlockstreamResearch/rust-simplicity#389, I added patch tests from

I used this pr BlockstreamResearch/rust-simplicity#402; it all works with our contracts.
A new one: BlockstreamResearch/rust-simplicity#403 doesn't compile.
Later, we should remove it.

Why do we need to sign with NativeSignature::Ecdsa in simplicity-std/tests/stdlib/common/core.rs?
The signing API changed in simplex, so it explicitly mentions what you sign instead of implicitly.
Before the refactor, we fell back to the last else case, which signed inputs.

@ikripaka
ikripaka requested a review from LesterEvSe October 13, 2026 08:07
@ikripaka ikripaka self-assigned this Oct 13, 2026
@ikripaka
ikripaka marked this pull request as draft October 13, 2026 15:06
@ikripaka
ikripaka force-pushed the feat/bump branch 2 times, most recently from 0f9690c to 2a76a8c Compare November 2, 2026 21:11
@ikripaka ikripaka changed the title Bump smplx-std dep to 0.1.1 Bump smplx-std dep to 0.2.0 Nov 2, 2026
@ikripaka
ikripaka marked this pull request as ready for review November 2, 2026 21:26

@LesterEvSe LesterEvSe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we need to add an entry to CHANGELOG.md stating that we:
- Bumped Simplex to 0.2.0..

Additionally, it is best to check whether the current version works with older versions and update README.md accordingly. To be precise, this line:

> [!NOTE]
> The library works with Simplex versions 0.x.x or higher.

Comment thread tests/stdlib/common/core.rs Resolved
Comment thread Cargo.toml Resolved
@ikripaka
ikripaka force-pushed the feat/bump branch 2 times, most recently from 33b4c92 to a1d621a Compare November 3, 2026 13:43
@ikripaka

ikripaka commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator Author

effef25 - apply lint suggestions
24baada - update Changelog and Readme

@LesterEvSe

Copy link
Copy Markdown
Collaborator

Note on the supported Simplex range, for future reference.

Users compile std's .simf sources with the SimplicityHL compiler that their Simplex bundles, so the lower bound mostly follows HL. Std doesn't use anything added after HL 0.6.0 (modules), which Simplex 0.0.7 bundles.

Developing std is stricter: the Rust test harness uses fuzz testing (added in Simplex 0.1.0) and APIs that changed in 0.2.0, so running the tests needs Simplex 0.2.0 or later. The user-side bound will move once std uses something newer, e.g. a simc version directive or enum. The Simplex.toml change in this PR only updates our commented-out template to the 0.2.0 one, so it has no effect on users.

nit (for later): we could move this into a dev doc (e.g. docs/dev/) to track it more explicitly as HL and Simplex evolve

@LesterEvSe LesterEvSe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3508a8c; tested locally with simplex test --test-threads 7 --no-fail-fast -- --release

@ikripaka
ikripaka requested a review from Hrom131 November 4, 2026 13:01
Base automatically changed from dev to master November 4, 2026 15:13
@ikripaka
ikripaka changed the base branch from master to dev November 4, 2026 15:25
@ikripaka

ikripaka commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

Rebased onto the new dev branch: b04a022.
Don't change any files.

@Hrom131 Hrom131 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hrom131
Hrom131 merged commit 931547a into dev Nov 5, 2026
5 of 6 checks passed
@Hrom131
Hrom131 deleted the feat/bump branch November 5, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants