Repository navigation
Conversation
0f9690c to
2a76a8c
Compare
LesterEvSe
left a comment
There was a problem hiding this comment.
Also, we need to add an entry to CHANGELOG.md stating that we:
- Bumped Simplex to 0.2.0..
Additionally, it is best to check whether the current version works with older versions and update README.md accordingly. To be precise, this line:
> [!NOTE]
> The library works with Simplex versions 0.x.x or higher.33b4c92 to
a1d621a
Compare
|
Note on the supported Simplex range, for future reference. Users compile std's Developing std is stricter: the Rust test harness uses fuzz testing (added in Simplex 0.1.0) and APIs that changed in 0.2.0, so running the tests needs Simplex 0.2.0 or later. The user-side bound will move once std uses something newer, e.g. a
|
LesterEvSe
left a comment
There was a problem hiding this comment.
ACK 3508a8c; tested locally with simplex test --test-threads 7 --no-fail-fast -- --release
* add local patch to pass the tests
|
Rebased onto the new |
Migrate simplicity-std to the
0.2.0simplex version.Format contracts with the simplex formatter, add CI check.
According to this issue: BlockstreamResearch/rust-simplicity#389, I added patch tests from
I used this pr BlockstreamResearch/rust-simplicity#402; it all works with our contracts.
A new one: BlockstreamResearch/rust-simplicity#403 doesn't compile.
Later, we should remove it.
Why do we need to sign with
NativeSignature::Ecdsainsimplicity-std/tests/stdlib/common/core.rs?The signing API changed in simplex, so it explicitly mentions what you sign instead of implicitly.
Before the refactor, we fell back to the last else case, which signed inputs.