Repository navigation
fix(molang): recognize attachable owning entity context - #740
Merged
DaanV2 merged 1 commit intoOct 18, 2026
Merged
Conversation
DaanV2
approved these changes
Oct 18, 2026
DaanV2
enabled auto-merge (squash)
October 18, 2026 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Attachable validation incorrectly reports
context.owning_entityand its shorthandc.owning_entityas undefined, even though the engine provides this context.Changes
owning_entityto the built-inAttachables.Contextsdata.This does not relax validation for custom contexts that still require definitions.
Validation
npm run build- passed.npm run lint- completed with 0 errors; existing warnings remain.npm test- 3569 passed and 1 skipped. Four snapshot failures remain infiles-test/files.test.tsbecause of command-text offsets. I reproduced the same four failures with this change stashed, confirming that they are unrelated to this PR.Fixes #739