Repository navigation
Conversation
Marzooqa
force-pushed
the
wci-895-me-eddsa-mpcv2-keygen-callbacks
branch
from
October 22, 2026 14:44
29584b4 to
6620841
Compare
Marzooqa
force-pushed
the
wci-918-me-eddsa-mpcv2-routing
branch
from
October 22, 2026 14:44
542a4c6 to
48339ed
Compare
3 tasks done
Marzooqa
force-pushed
the
wci-895-me-eddsa-mpcv2-keygen-callbacks
branch
from
October 22, 2026 16:53
6620841 to
7bdeff8
Compare
Marzooqa
force-pushed
the
wci-918-me-eddsa-mpcv2-routing
branch
from
October 22, 2026 16:54
48339ed to
9510242
Compare
Marzooqa
force-pushed
the
wci-895-me-eddsa-mpcv2-keygen-callbacks
branch
from
October 23, 2026 13:58
7bdeff8 to
2d2a6c1
Compare
Marzooqa
force-pushed
the
wci-918-me-eddsa-mpcv2-routing
branch
from
October 23, 2026 13:58
9510242 to
0c88fc7
Compare
For EdDSA TSS coins, read the enterprise's wallet creation multiSigTypeVersion from /api/v2/tss/settings (the setting BitGoJS uses) and hand the SDK the EdDSA MPCv2 callbacks when it is MPCv2, MPCv1 otherwise. Moving to MPCv2 only is then a server-side change. Ticket: WCI-918 Co-Authored-By: Claude <noreply@anthropic.com>
Marzooqa
force-pushed
the
wci-918-me-eddsa-mpcv2-routing
branch
from
October 23, 2026 14:12
0c88fc7 to
a76dfb7
Compare
Marzooqa
force-pushed
the
wci-895-me-eddsa-mpcv2-keygen-callbacks
branch
from
October 23, 2026 14:12
2d2a6c1 to
849d1b3
Compare
Marzooqa
marked this pull request as ready for review
October 23, 2026 14:21
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
pranishnepal
approved these changes
Oct 23, 2026
kisslove-dewangan
approved these changes
Oct 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
handleGenerateWalletreads the enterprise's wallet creationmultiSigTypeVersionfromGET /api/v2/tss/settings(the same setting and call BitGoJS uses inkeychains.createMpcand the ECDSA external signer path).MPCv2-> the SDK getseddsaMPCv2Callbacks(createEddsaMPCv2KeyGenCallbacks)eddsaCallbacks, the existing MPCv1 flowWhy
Dependencies
Test plan
generateWallet.test.ts(SDK call stubbed,/tss/settingsnocked): MPCv2 setting useseddsaMPCv2Callbacksonly; absent setting keepseddsaCallbacks; a setting for a different coin family is ignored; ECDSA does not read the setting/tss/settings(no MPCv2 setting)tsc --noEmit, ESLint, commitlint and the OpenAPI drift check clean; full suite passing (467 tests)Ticket: WCI-918