Repository navigation
fix(express): emit format number for BigIntFromString in OpenAPI spec - #10164
Open
Charan-Ratlan wants to merge 1 commit into
Open
Charan-Ratlan wants to merge 1 commit into
Charan-Ratlan wants to merge 1 commit into
Conversation
The express OpenAPI codec config overrides the io-ts-types
BigIntFromString handler to a plain { type: 'string' }. Because the
generator merges custom config per module, this replaced the built-in
handler, which emits { type: 'string', format: 'number' }.
wallet-platform has no io-ts-types override and uses the built-in
handler, so shared @bitgo/public-types components such as
LightningOnchainRequest and LightningPaymentRequest were generated
differently in express.yaml and wallet-platform.yaml. The api-docs
static analysis then flagged them, and the schemas that reference
them, as colliding components.
Set the override to the built-in output so both specs match.
Ticket: WCI-2237
Contributor
Contributor
|
|
Charan-Ratlan
requested a deployment
to
breaking-changes-override
November 11, 2026 10:45 — with
GitHub Actions
Waiting
Charan-Ratlan
marked this pull request as ready for review
November 11, 2026 11:06
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
vibhavgo
approved these changes
Nov 13, 2026
pranishnepal
approved these changes
Nov 13, 2026
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The express OpenAPI codec config overrides the io-ts-types BigIntFromString handler to a plain { type: 'string' }. Because the generator merges custom config per module, this replaced the built-in handler, which emits { type: 'string', format: 'number' }.
wallet-platform has no io-ts-types override and uses the built-in handler, so shared @bitgo/public-types components such as LightningOnchainRequest and LightningPaymentRequest were generated differently in express.yaml and wallet-platform.yaml. The api-docs static analysis then flagged them, and the schemas that reference them, as colliding components.
Set the override to the built-in output so both specs match.
Ticket: WCI-2237