Skip to content

fix(express): emit format number for BigIntFromString in OpenAPI spec - #10164

Open
Charan-Ratlan wants to merge 1 commit into
masterfrom
WCI-2237
Open

Charan-Ratlan wants to merge 1 commit into
masterfrom
WCI-2237

Conversation

@Charan-Ratlan

Copy link
Copy Markdown
Contributor

The express OpenAPI codec config overrides the io-ts-types BigIntFromString handler to a plain { type: 'string' }. Because the generator merges custom config per module, this replaced the built-in handler, which emits { type: 'string', format: 'number' }.

wallet-platform has no io-ts-types override and uses the built-in handler, so shared @bitgo/public-types components such as LightningOnchainRequest and LightningPaymentRequest were generated differently in express.yaml and wallet-platform.yaml. The api-docs static analysis then flagged them, and the schemas that reference them, as colliding components.

Set the override to the built-in output so both specs match.

Ticket: WCI-2237

The express OpenAPI codec config overrides the io-ts-types
BigIntFromString handler to a plain { type: 'string' }. Because the
generator merges custom config per module, this replaced the built-in
handler, which emits { type: 'string', format: 'number' }.

wallet-platform has no io-ts-types override and uses the built-in
handler, so shared @bitgo/public-types components such as
LightningOnchainRequest and LightningPaymentRequest were generated
differently in express.yaml and wallet-platform.yaml. The api-docs
static analysis then flagged them, and the schemas that reference
them, as colliding components.

Set the override to the built-in output so both specs match.

Ticket: WCI-2237
@linear-code

linear-code Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

WCI-2237

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Compatibility checks are failing on Node.js 27-nightly (experimental, non-blocking). This does not block merge, but it signals an incompatibility to fix before this release becomes supported.

View run

@Charan-Ratlan
Charan-Ratlan requested a deployment to breaking-changes-override November 11, 2026 10:45 — with GitHub Actions Waiting
@Charan-Ratlan
Charan-Ratlan marked this pull request as ready for review November 11, 2026 11:06
@Charan-Ratlan
Charan-Ratlan requested review from a team as code owners November 11, 2026 11:06

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

This branch is waiting to be deployed

1 waiting deployment
breaking-changes-override — b06c00ae Waiting Nov 11, 2026 by Charan-Ratlan via Linter Override #6247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants