fix(sdk-core): bind GG18 offline shares to signable, enforce single use by vibhavgo · Pull Request #10126 · BitGo/BitGoJS

vibhavgo · 2026-11-04T08:51:23Z

Summary

Security hardening for the external-signing (signer mode) flow in BitGo Express and the SDK. Details are tracked in the linked ticket.

Linear: WAL-2459

Changes

Hardens offline signing share handling in the SDK (authenticated binding, expiry, counterparty input checks, single-use tracking).
Adds a configurable single-use registry on the Express signer (--signerRegistryFilePath / BITGO_SIGNER_REGISTRY_FILE_PATH).
Documents external-signer operational requirements in the Express README.

Test Plan

Full express and bitgo unit suites, plus new unit coverage for the share helpers and the registry.

linear-code · 2026-11-04T08:51:31Z

WAL-2459

github-actions · 2026-11-04T08:53:22Z

⚠️ Compatibility checks are failing on Node.js 27-nightly (experimental, non-blocking). This does not block merge, but it signals an incompatibility to fix before this release becomes supported.

View run

vibhavgo · 2026-11-04T09:34:56Z

@claude review always

vibhavgo · 2026-11-04T11:38:04Z

@claude review

vibhavgo · 2026-11-04T12:55:08Z

@claude review

claude

Code review completed

Nothing new to post: everything this review found is already covered by existing comments on this pull request or didn't merit a separate one.

vibhavgo · 2026-11-04T16:01:47Z

@claude review

vibhavgo · 2026-11-05T06:03:38Z

@claude review

claude

Code review completed

Nothing new to post: everything this review found is already covered by existing comments on this pull request or didn't merit a separate one.

vibhavgo · 2026-11-05T06:47:28Z

@claude review

vibhavgo · 2026-11-05T08:13:39Z

@claude review

claude

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}

claude

No new blocking issues. 1 optional suggestion (a nit or a note on pre-existing code) was found and not posted. Nothing in this review needs a push before merging.

Marzooqa

Overall: Solid change — fail-closed semantics throughout (post-decrypt marking, atomic persist, fail-closed load) and thorough test coverage. Suggestions and a question inline; none blocking.

Rollout note for the description: envelopes minted by pre-PR code carry no adata and fail closed, so in-flight signing sessions restart at deploy.

claude

No new blocking issues. 1 optional suggestion (a nit or a note on pre-existing code) was found and not posted. Nothing in this review needs a push before merging.

Adds authenticated binding, expiry and counterparty checks to the offline signing share helpers, and a configurable single-use consumption registry on the Express signer. Security hardening for the external-signing (signer mode) flow. References: WAL-2459

claude

No new blocking issues. 1 optional suggestion (a nit or a note on pre-existing code) was found and not posted. Nothing in this review needs a push before merging.

vibhavgo force-pushed the vibhavgopalkrishna/wal-2459-critical-bitgojs-gg18-external-signer-s-share-helper-accepts branch from 1e9b6e9 to bcf118a Compare November 4, 2026 08:54

This comment was marked as outdated.

Sign in to view

vibhavgo force-pushed the vibhavgopalkrishna/wal-2459-critical-bitgojs-gg18-external-signer-s-share-helper-accepts branch 2 times, most recently from 15a3678 to 7f281e8 Compare November 4, 2026 11:01

This comment was marked as outdated.

Sign in to view

claude Bot reviewed Nov 4, 2026

View reviewed changes

Comment thread modules/sdk-core/src/bitgo/utils/tss/ecdsa/ecdsa.ts Resolved

vibhavgo force-pushed the vibhavgopalkrishna/wal-2459-critical-bitgojs-gg18-external-signer-s-share-helper-accepts branch from 7f281e8 to b043dee Compare November 4, 2026 12:22

This comment was marked as outdated.

Sign in to view

claude Bot reviewed Nov 4, 2026

View reviewed changes

vibhavgo force-pushed the vibhavgopalkrishna/wal-2459-critical-bitgojs-gg18-external-signer-s-share-helper-accepts branch 2 times, most recently from ba73606 to 9642a04 Compare November 4, 2026 14:15

This comment was marked as outdated.

Sign in to view

claude Bot reviewed Nov 4, 2026

View reviewed changes

Comment thread modules/express/src/clientRoutes.ts Resolved

vibhavgo force-pushed the vibhavgopalkrishna/wal-2459-critical-bitgojs-gg18-external-signer-s-share-helper-accepts branch from 9642a04 to 3036ebc Compare November 4, 2026 17:07

This comment was marked as outdated.

Sign in to view

claude Bot reviewed Nov 5, 2026

View reviewed changes

vibhavgo force-pushed the vibhavgopalkrishna/wal-2459-critical-bitgojs-gg18-external-signer-s-share-helper-accepts branch from 3036ebc to f2807d4 Compare November 5, 2026 06:36

This comment was marked as outdated.

Sign in to view

vibhavgo force-pushed the vibhavgopalkrishna/wal-2459-critical-bitgojs-gg18-external-signer-s-share-helper-accepts branch from f2807d4 to 1413b87 Compare November 5, 2026 07:21

vibhavgo force-pushed the vibhavgopalkrishna/wal-2459-critical-bitgojs-gg18-external-signer-s-share-helper-accepts branch from 72c442b to 7b881e4 Compare November 6, 2026 10:43

vibhavgo marked this pull request as ready for review November 6, 2026 11:32

vibhavgo requested review from a team as code owners November 6, 2026 11:32

vibhavgo requested review from davidkaplanbitgo and lokesh-bitgo November 6, 2026 11:32

claude Bot reviewed Nov 6, 2026

View reviewed changes

vibhavgo requested a review from kisslove-dewangan November 10, 2026 05:34

vibhavgo force-pushed the vibhavgopalkrishna/wal-2459-critical-bitgojs-gg18-external-signer-s-share-helper-accepts branch 2 times, most recently from 82813fa to d9a6515 Compare November 10, 2026 05:50

claude Bot reviewed Nov 10, 2026

View reviewed changes

Comment thread modules/express/README.md Resolved

This comment was marked as outdated.

Sign in to view

vibhavgo force-pushed the vibhavgopalkrishna/wal-2459-critical-bitgojs-gg18-external-signer-s-share-helper-accepts branch from d9a6515 to 25507aa Compare November 10, 2026 06:19

claude Bot reviewed Nov 10, 2026

View reviewed changes

Comment thread modules/express/src/expressApp.ts Resolved

vibhavgo force-pushed the vibhavgopalkrishna/wal-2459-critical-bitgojs-gg18-external-signer-s-share-helper-accepts branch from 25507aa to 7cf247f Compare November 10, 2026 06:27

claude Bot reviewed Nov 10, 2026

View reviewed changes

Marzooqa mentioned this pull request Nov 10, 2026

fix(sdk-core): redact EdDSA MPCv1 R share, bind G round to signer-held envelope #10154

Draft

Marzooqa reviewed Nov 10, 2026

View reviewed changes

Marzooqa mentioned this pull request Nov 10, 2026

fix: validate BitGo GPG key and session state in ECDSA MPCv2 offline signing #10155

Merged

vibhavgo force-pushed the vibhavgopalkrishna/wal-2459-critical-bitgojs-gg18-external-signer-s-share-helper-accepts branch from 7cf247f to 4199628 Compare November 11, 2026 07:09

claude Bot reviewed Nov 11, 2026

View reviewed changes

vibhavgo force-pushed the vibhavgopalkrishna/wal-2459-critical-bitgojs-gg18-external-signer-s-share-helper-accepts branch from 4199628 to a1a6510 Compare November 11, 2026 08:23

claude Bot reviewed Nov 11, 2026

View reviewed changes

vibhavgo requested a review from Marzooqa November 11, 2026 08:49

Marzooqa approved these changes Nov 11, 2026

View reviewed changes

vibhavgo merged commit f635f77 into master Nov 11, 2026
33 checks passed

vibhavgo deleted the vibhavgopalkrishna/wal-2459-critical-bitgojs-gg18-external-signer-s-share-helper-accepts branch November 11, 2026 11:33

Marzooqa mentioned this pull request Nov 11, 2026

fix: validate BitGo GPG key and session state in EdDSA MPCv2 offline signing #10127

Merged

Conversation

vibhavgo commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test Plan

Uh oh!

linear-code Bot commented Nov 4, 2026

Uh oh!

github-actions Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vibhavgo commented Nov 4, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

vibhavgo commented Nov 4, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

vibhavgo commented Nov 4, 2026

Uh oh!

This comment was marked as outdated.

claude Bot left a comment

Choose a reason for hiding this comment

Uh oh!

vibhavgo commented Nov 4, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

vibhavgo commented Nov 5, 2026

Uh oh!

This comment was marked as outdated.

claude Bot left a comment

Choose a reason for hiding this comment

Uh oh!

vibhavgo commented Nov 5, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

vibhavgo commented Nov 5, 2026

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Marzooqa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Uh oh!

claude Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vibhavgo commented Nov 4, 2026 •

edited

Loading

github-actions Bot commented Nov 4, 2026 •

edited

Loading