Repository navigation
feat(sdk-core): reshare wallets to recovering spenders - #10100
Draft
ralph-bitgo[bot] wants to merge 1 commit into
Draft
ralph-bitgo[bot] wants to merge 1 commit into
ralph-bitgo[bot] wants to merge 1 commit into
Conversation
Contributor
ralph-bitgo
Bot
force-pushed
the
wcn-3894-reshare-wallet-recovery
branch
from
October 29, 2026 17:34
3302561 to
27a11c7
Compare
Add admin and recovery filters and report per-recipient outcomes. This lets custody lightning wallet members regain spending access after their userAuth key is reset without one blocked share stopping the remaining recipients. BREAKING CHANGE: recipient share failures are returned rather than thrown; callers must inspect the failed results. Ticket: WCN-3894 Session-Id: 3e80d32f-b610-4dde-bcdf-73d89ebe4147 Task-Id: ce5e1cc0-4061-4fb5-a492-2234993dadd8
ralph-bitgo
Bot
force-pushed
the
wcn-3894-reshare-wallet-recovery
branch
from
October 29, 2026 17:35
27a11c7 to
fc6965b
Compare
![ralph-bitgo[bot]](https://avatars.githubusercontent.com/in/4074619?s=60&v=4){kind=small}
| (user) => | ||
| user.permissions.includes('spend') && | ||
| (opts?.includeAdmins || !user.permissions.includes('admin')) && | ||
| (!opts?.onlyNeedsRecovery || user.needsRecovery === true) && |
Author
There was a problem hiding this comment.
I require an explicit true so members without recovery metadata are not accidentally reshared during a reset. The admin and recovery filters remain independent.
| await wallet.shareWallet(shareOptions); | ||
| result.shared.push(user.user); | ||
| } catch (e) { | ||
| result.failed.push({ userId: user.user, error: e instanceof Error ? e.message : String(e) }); |
Author
There was a problem hiding this comment.
I keep wallet-wide setup failures outside this catch so an incorrect password still rejects the operation; individual recipient failures allow subsequent shares to proceed.
Contributor
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add optional admin and recovery-status filters to
reshareWalletWithSpenders, expose the method and result types onIWallets, and return per-user successes and failures while continuing through the recipients. Setup and decryption failures still reject. Existing default recipient selection is unchanged, but recipient failures are now returned instead of thrown.After a custody lightning userAuth key reset, other wallet members need the new key to regain spending access; an existing share must not prevent other members from being reshared. Coordinate publication in the same beta as the sibling abstract-lightning change.
Issue Number
WCN-3894
Type of change
How Has This Been Tested?
yarn lerna run build --scope bitgo --scope @bitgo/express --include-dependencies --concurrency 2in the Nix shell.Checklist: