Repository navigation
Ap 863 cleanup - #9
Merged
Merged
Conversation
jason-raitz
commented
Oct 6, 2026
jason-raitz
commented
Contributor
- aligns volume mounts for local development with mokelumne
- also adds tests for empty filelist in a submission
- removes files/.keep
- also adds empty filelist tests
steve-sullivan
approved these changes
Oct 7, 2026
steve-sullivan
left a comment
steve-sullivan
left a comment
Contributor
There was a problem hiding this comment.
Looks great! r+
I do have one question below about privileges, but it's not a blocker or anything like that.
| volumes: | ||
| - ./:/app | ||
| - ./files:/srv/files:ro | ||
| - ./tmp:/srv |
Contributor
There was a problem hiding this comment.
Just curious if the app container needs write access to /srv, or could this remain read-only for app and writable for the worker?
Contributor
Author
There was a problem hiding this comment.
I think you're right!
awilfox
reviewed
Oct 9, 2026
awilfox
left a comment
awilfox
left a comment
Member
There was a problem hiding this comment.
r+wc: This seems fine with a single doc improvement.
Co-authored-by: Anna Wilcox <AWilcox@Wilcox-Tech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.