[tastybento]

Problem

An admin reported a lava dupe on BSkyBlock (3.22.3). ObsidianScoopingListener checks the obsidian and the bucket on the right-click, then hands out the lava one tick later in givePlayerLava. That delayed step re-checked nothing:

• If the obsidian was mined within that tick, the player kept the obsidian drop and got the lava bucket.
• It decremented the ItemStack captured from the event. If the bucket had been moved out of the hand in the meantime, lava could be given without using up a bucket.

The listener is unchanged between 3.22.3 and develop.

Fix

givePlayerLava now re-checks before doing anything, and does nothing if any check fails:

• the player is still online;
• the block is still obsidian;
• the hand that clicked still holds an empty bucket. The bucket is read fresh from that hand slot instead of using the stale event item.

The "scooping" message and the lava sound moved into givePlayerLava, so they only play when lava is actually given. The 1-minute cooldown is still applied at click time, so a cancelled attempt still costs the cooldown.

Testing

• New unit tests for the success path, obsidian gone, bucket no longer in hand, and player offline. All worldsettings listener tests pass; I didn't run the full suite.
• Deployed to a local 26.3 test server.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud