Skip to content

core: Pin fixtures and tutorials to stable v32.0 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
BenWestgate wants to merge 1 commit into
base: reviewability-v1
Choose a base branch
from
Draft

core: Pin fixtures and tutorials to stable v32.0 #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/bitcoin-core-fixtures.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ permissions:
contents: read

env:
BITCOIN_CORE_ARCHIVE: bitcoin-32.0rc2-x86_64-linux-gnu.tar.gz
BITCOIN_CORE_SHA256: 0255103718033e6aee15fa944717fc277e047b845bff1e7408af0ea732d8d0c1
BITCOIN_CORE_URL: https://bitcoincore.org/bin/bitcoin-core-32.0/test.rc2
BITCOIN_CORE_ARCHIVE: bitcoin-32.0-x86_64-linux-gnu.tar.gz
BITCOIN_CORE_SHA256: 512d95d64591ddd1a74390cbfdd41b1c1a4f5494531d78db46ec8fdacafbeb71
BITCOIN_CORE_URL: https://bitcoincore.org/bin/bitcoin-core-32.0

jobs:
verify:
Expand All @@ -41,7 +41,7 @@ jobs:
env:
PYTHONPATH: ${{ github.workspace }}/src
run: |
core="$RUNNER_TEMP/bitcoin-32.0rc2/bin"
core="$RUNNER_TEMP/bitcoin-32.0/bin"
"$core/bitcoind" --version | head -1
python tools/bitcoin_core_regtest.py \
--bitcoind "$core/bitcoind" \
Expand Down
8 changes: 4 additions & 4 deletions docs/developer/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,10 +653,10 @@ xprv through `bitcoin-cli -stdin`, asks Core to create account-0 descriptors,
and relocks an encrypted destination after success, failure, or
interruption. It never handles a passphrase.

For offline signing/watch-only and multisig workflows, use Bitcoin Core v32's
maintained procedures. Until the final v32 release, see the versioned
[offline-signing tutorial](https://github.com/bitcoin/bitcoin/blob/v32.0rc1/doc/offline-signing-tutorial.md)
and [multisig tutorial](https://github.com/bitcoin/bitcoin/blob/v32.0rc1/doc/multisig-tutorial.md).
For offline signing/watch-only and multisig workflows, use Bitcoin Core v32.0's
maintained, versioned procedures:
[offline-signing tutorial](https://github.com/bitcoin/bitcoin/blob/v32.0/doc/offline-signing-tutorial.md)
and [multisig tutorial](https://github.com/bitcoin/bitcoin/blob/v32.0/doc/multisig-tutorial.md).
The direct `ms32 xprv` primitive remains top-level and carries an explicit
secret-root warning.

Expand Down
6 changes: 3 additions & 3 deletions docs/user/guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ keys enabled and run `ms32 wallet`. Keep that computer disconnected from every
network while recovery text or signing keys are present.

After the signer is restored, follow Bitcoin Core v32's maintained
[offline-signing tutorial](https://github.com/bitcoin/bitcoin/blob/master/doc/offline-signing-tutorial.md).
[offline-signing tutorial](https://github.com/bitcoin/bitcoin/blob/v32.0/doc/offline-signing-tutorial.md).
That workflow owns the watch-only export/import and PSBT transport steps. In
Bitcoin Core v32, `exportwatchonlywallet` creates the watch-only wallet file and
`restorewallet` loads it on the online node. Do not improvise a codex32-specific
Expand Down Expand Up @@ -245,7 +245,7 @@ its public wallet data with the separate wallet record.
account-0 descriptors, scans history, and relocks an encrypted wallet.
6. If you need an online watch-only counterpart, keep the restored signer
offline and follow Bitcoin Core v32's
[offline-signing tutorial](https://github.com/bitcoin/bitcoin/blob/master/doc/offline-signing-tutorial.md)
[offline-signing tutorial](https://github.com/bitcoin/bitcoin/blob/v32.0/doc/offline-signing-tutorial.md)
to export and restore the watch-only wallet. Let the online node synchronize,
then compare the account, policy, addresses, balance, and transaction
history with the wallet record.
Expand All @@ -264,7 +264,7 @@ results disagree, or the wallet is multisig or nonstandard.

Restore the cosigner's private Bitcoin Core wallet with `ms32 wallet`, then
follow Bitcoin Core v32's maintained
[multisig tutorial](https://github.com/bitcoin/bitcoin/blob/v32.0rc1/doc/multisig-tutorial.md).
[multisig tutorial](https://github.com/bitcoin/bitcoin/blob/v32.0/doc/multisig-tutorial.md).

### Card maintenance and damaged writing

Expand Down
Loading