Repository navigation
create: Keep cleaning up after Ctrl-C while deleting wallet files - #160
BenWestgate wants to merge 1 commit into
Conversation
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted current-head review.
Code ACK 539e08f (static). Catching an interrupt at folder removal or RAM-disk detach lets the remaining cleanup run, then reports any leftover path; tests cover both interruption points. Keep stacked on #145; exercise real Tails/macOS cleanup before release.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
539e08f to
3e5b1f0
Compare
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted incremental review of 3e5b1f0: Concept ACK. Interrupted file removal and RAM-disk detachment now continue other cleanup and fail closed if anything remains. Independently reran the Core/CLI/public-API unit tests: 314 passed. Bitcoin Core 32 integration/signal tests remain outstanding; not a runtime security ACK.
|
AI-assisted integration follow-up for |
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Ctrl-C during the folder delete or the macOS RAM disk detach escaped before the other step ran and before the user was told what was left. Both steps now catch it like the RPC steps do, so cleanup finishes and anything still on disk is named in the error that stops creation. Claude-Session: https://claude.ai/code/session_01T233rKgZqE5wzDm3EVTHL1
3e5b1f0 to
3d5f877
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Ctrl-C, SIGHUP or SIGTERM during wallet-folder deletion or macOS RAM-disk detach used to escape before the other cleanup step ran and before the user was told what remained.
Catch interruption in both steps so cleanup finishes and any remaining resource is named in the creation-stopping error. Two tests interrupt each cleanup step.
Stacked on #201.