Repository navigation
tests: Match Core initializer signature - #117
Conversation
BenWestgate
added
ci
90b9efe to
6fc7e68
Compare
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
AI-generated review (Codex), posted at the maintainer's request.
ACK 6fc7e68. The test fake now matches the actual initializer signature.
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
Codex current-head review at 6fc7e68: no findings. The test double now matches the current BitcoinCore.initialize signature.
|
@codex review Please review current head |
This comment has been minimized.
This comment has been minimized.
Remove the obsolete `private` keyword from the CLI test double so its initializer matches the production BitcoinCore API. Refs #38.
6fc7e68 to
f4004a3
Compare
This comment has been minimized.
This comment has been minimized.
|
@codex review |
This comment has been minimized.
This comment has been minimized.
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted current-head review: ACK f4004a3. This is exactly the intended test-only cleanup: _FakeBitcoinCore.initialize no longer accepts the obsolete private= keyword that production BitcoinCore.initialize does not accept. No runtime code changes. Exact-head Python-package CI is green and there are no unresolved review threads.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Refs #38.
The prior dead-code cleanup removed the unused fake state but left its obsolete private= keyword in _FakeBitcoinCore.initialize. Production BitcoinCore.initialize does not accept that keyword. Remove the one parameter so future accidental calls fail in CLI tests instead of only against real Core.
Verification: 232 CLI tests passed on this branch; git diff --check passes. No runtime code changed.
AI assistance was used to find and prepare this one-line test correction. Human review remains with the maintainer.