Skip to content

Add option to enable/disable warning as error #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SunBlack wants to merge 1 commit into from
+14 −11
Closed

Add option to enable/disable warning as error #1293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ option(BTCPP_SQLITE_LOGGING "Add SQLite logging." ON)
option(BTCPP_ENABLE_ASAN "Enable Address Sanitizer" OFF)
option(BTCPP_ENABLE_UBSAN "Enable Undefined Behavior Sanitizer" OFF)
option(BTCPP_ENABLE_TSAN "Enable Thread Sanitizer" OFF)
option(BTCPP_ENABLE_WARNING_AS_ERROR "Specify whether to treat warnings on compile as errors." ON)

option(USE_V3_COMPATIBLE_NAMES "Use some alias to compile more easily old 3.x code" OFF)
option(ENABLE_FUZZING "Enable fuzzing builds" OFF)
Expand Down Expand Up @@ -294,17 +295,19 @@ endif()

add_library(BT::${BTCPP_LIBRARY} ALIAS ${BTCPP_LIBRARY})

# Downstream projects (e.g. Nav2) compile our public headers with -Werror, so
# the library and every target below that instantiates them must be
# warning-free (issue #1288). -Wnull-dereference only fires with optimization.
# Set after the 3rdparty subdirectories, so vendored code is not affected.
if(MSVC)
# C4702 (unreachable code) is a code-generation warning that fires on
# instantiation-dependent `if constexpr` tails; GCC/Clang have no
# equivalent in -Wall -Wextra.
set(BTCPP_WARNING_FLAGS /W4 /WX /permissive- /wd4702)
else()
set(BTCPP_WARNING_FLAGS -Wall -Wextra -Wpedantic -Wnull-dereference -Werror)
if(BTCPP_ENABLE_WARNING_AS_ERROR)
# Downstream projects (e.g. Nav2) compile our public headers with -Werror, so
# the library and every target below that instantiates them must be
# warning-free (issue #1288). -Wnull-dereference only fires with optimization.
# Set after the 3rdparty subdirectories, so vendored code is not affected.
if(MSVC)
# C4702 (unreachable code) is a code-generation warning that fires on
# instantiation-dependent `if constexpr` tails; GCC/Clang have no
# equivalent in -Wall -Wextra.
set(BTCPP_WARNING_FLAGS /W4 /WX /permissive- /wd4702)
else()
set(BTCPP_WARNING_FLAGS -Wall -Wextra -Wpedantic -Wnull-dereference -Werror)
endif()
endif()
target_compile_options(${BTCPP_LIBRARY} PRIVATE ${BTCPP_WARNING_FLAGS})
add_compile_options(${BTCPP_WARNING_FLAGS})
Expand Down
Loading