Repository navigation
Honor pre- and post-conditions in ThreadedAction - #1286
Merged
facontidavide merged 1 commit intoNov 13, 2026
Merged
Conversation
`ThreadedAction::executeTick()` overrides `TreeNode::executeTick()` without calling it, so the pre-conditions (`_skipIf`, `_failureIf`, `_successIf`, `_while`, `_onlyIf`, `_onStart`) and the post-conditions (`_onSuccess`, `_onFailure`, `_post`) were ignored on all subclasses of `ThreadedAction`: e.g. a node with `_skipIf="true"` was still ticked. Check them as `TreeNode::executeTick()` does. The pre- and post-tick callbacks are still not called for threaded actions. Signed-off-by: Gaël Écorchard <gael@km-robotics.cz>
Collaborator
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThreadedAction::executeTick()overridesTreeNode::executeTick()without calling it, so the pre-conditions (_skipIf,_failureIf,_successIf,_while,_onlyIf,_onStart) and the post-conditions (_onSuccess,_onFailure,_post) were ignored on all subclasses ofThreadedAction: e.g. a node with_skipIf="true"was still ticked.Check them as
TreeNode::executeTick()does. The pre- and post-tick callbacks are still not called for threaded actions.