Repository navigation
docs(sdkharness): run one check against the standalone simulator - #625
Merged
Merged
Conversation
Rewrite the README's local-run steps to use backblaze-labs/b2-simulator (via B2SIM_DIR) instead of central-harness-only paths, list every proxy variable the leaf checks scrub, and move the _JournalServer test helper's imports to module level. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Drop links to private repositories, say the standalone simulator is available to the team, show the full loopback_guard.py path, note the Python 3.10+ requirement, and stop each example's simulator before the next so copy-paste runs get a fresh one. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #623 and #624.
.sdkharness/README.md: the 'Run one check locally' steps no longer point at central-harness-only paths (/tmp/b2-simulator/...,sdkharness/bin/simulator/serve.mjs). They now clone or reuse the privatebackblaze-labs/b2-simulatorviaB2SIM_DIR, start it with--control, and run one conformance, resilience and health scenario through the dispatchers. Node requirement corrected to 20+ (the simulator's engines floor). Every command was run against a loopback simulator and printed a PASSSDKHARNESS_RESULTline.HTTP_PROXY,HTTPS_PROXY,ALL_PROXY,FTP_PROXY,NO_PROXY,REQUEST_METHOD, thenNO_PROXYpinned), matchinglib/loopback_guard.py._JournalServerhelper's imports moved to module level.unreachable/unauthorizedentries in the conformance leaves'REASONStuples. They are never raised, but ~34 files carry them and no test covers the tuples, so it was not a trivial, covered change.Verified:
pytest test/unit/test_sdkharness*.py(118 passed),ruff checkandruff format --checkon the touched test file.🤖 Generated with Claude Code