Repository navigation
test(sdkharness): upload.stall runs through the CLI's CI request-timeout hook - #1186
Open
sophiecarreras wants to merge 1 commit into
Open
sophiecarreras wants to merge 1 commit into
sophiecarreras wants to merge 1 commit into
Conversation
…out hook
The check hard-coded Skip('no-client-option') because the CLI has no timeout option.
b2/_internal/_cli/b2api.py shortens the b2sdk timeouts (TIMEOUT_FOR_UPLOAD=24, TRY_COUNT_DATA=2)
when CI is set and GITHUB_REPOSITORY ends with /B2_Command_Line_Tool. The stall scenario now
sets both in the CLI subprocess environment only; the product code is unchanged.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
mpnowacki-reef
force-pushed
the
master
branch
from
October 23, 2026 08:43
469f200 to
9ea898a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The sdkharness
upload.stallcheck (.sdkharness/tests/resilience-upload.py) used to reportSKIP no-client-optionbecause it hard-coded that the CLI has no per-request timeout shorter than the 60 s controlled stall. It now runs. For that scenario only, the CLI subprocess getsCI=1andGITHUB_REPOSITORY=Backblaze/B2_Command_Line_Tool, then the existing wire-fault path asserts from the simulator journal that exactly one stall fired, that a laterb2_upload_filereturned 200 on a differentuploadUrlId, and that the file reads back intact.Why this is possible
b2/_internal/_cli/b2api.pyalready shortens the b2sdk request timeouts whenCIis set andGITHUB_REPOSITORYends with/B2_Command_Line_Tool(TIMEOUT_FOR_UPLOAD = 24,TRY_COUNT_DATA = 2, among others), which is the setting the CLI's own CI relies on. With it, a 60 s stalled upload is abandoned after 24 s and retried on a new upload URL. The product code is unchanged; only.sdkharness/and a changelog fragment change. The other scenarios keep the stripped environment they had.Checked
Against the standalone simulator only (no real B2, fake credentials):
bin/run-resilience.sh --scenario upload.stall B2_Command_Line_Toolfrom the sdkharness, pointed at a checkout of this branch: PASS, about 25 s (the runner only accepts a PASS when the journal shows the stall fired). Journal of that run:Tracks backblaze-labs/demand-side-ai#1354 (same case as the Python one, Backblaze/b2-sdk-python#628).
🤖 Generated with Claude Code