Repository navigation

Add File / FileReader polyfill - #169

Merged

bkaradzic-microsoft merged 13 commits into

BabylonJS:mainfrom

bkaradzic-microsoft:weekend/tpc-1582-file-polyfill

Jun 5, 2026

Merged

Add File / FileReader polyfill#169
bkaradzic-microsoft merged 13 commits into
BabylonJS:mainfrom
bkaradzic-microsoft:weekend/tpc-1582-file-polyfill

Commits on Jun 4, 2026
- Add File / FileReader polyfill
  
  bkaradzic
  and
  Copilot
  committed
  4d29e69
- fix(File): revert to `throw Napi::TypeError`; comment-out throw test on Chakra
  
  bkaradzic
  and
  Copilot
  committed
  afcd679
- review(File): drop readAsBinaryString, File extends Blob, drop shared_ptr trick
  
  bkaradzic-microsoft
  authored and
  Copilot
  committed
  13b026b
- fix(File): JSC prototype-chain wire-up via temp-instance trick
  
  bkaradzic-microsoft
  authored and
  Copilot
  committed
  fb73ee9
- File: try direct setPrototypeOf first, fall back to temp-instance
  
  bkaradzic-microsoft
  authored and
  Copilot
  committed
  68e305c
- File: do prototype-chain wire-up in JS so JSC errors stay caught
  
  bkaradzic-microsoft
  authored and
  Copilot
  committed
  148877c
- File polyfill: address non-controversial review nits from bghgary on #169
  
  bkaradzic-microsoft
  and
  Copilot
  committed
  e34af33
- File polyfill: drop JS_PROTOTYPE_CHAIN_SHIM workaround now that #177 landed
  
  bkaradzic-microsoft
  and
  Copilot
  committed
  be71aed
- File: drop #177 historical paragraph from setPrototypeOf comment
  
  bkaradzic-microsoft
  and
  Copilot
  committed
  fe457e5
- FileReader: back readonly + on* attributes with C++ state via InstanceAccessor
  
  bkaradzic-microsoft
  and
  Copilot
  committed
  eaeaf20
- FileReader: encode data: URLs via base-n instead of a bespoke base64 impl
  
  bkaradzic-microsoft
  and
  Copilot
  committed
  a6155da
- FileReader: box result/error so string results survive real N-API
  
  bkaradzic-microsoft
  and
  Copilot
  committed
  14122f1
- FileReader: anchor in-flight read via lambda-owned ref, not a self-cycle
  
  bkaradzic
  and
  Copilot
  committed
  61d9924

Commits

Commits on Jun 4, 2026