Repository navigation
Update BabylonNative to f4d9efb - #770
Merged
Merged
Conversation
Pin the latest BabylonNative master revision, including the JsRuntimeHost dependency update. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 74d06f45-92ac-4835-acc2-8ed89229b9eb
Update iOS and Windows consumers after BabylonNative stopped producing the minz library; refresh the iOS podspec checksum. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 74d06f45-92ac-4835-acc2-8ed89229b9eb
CedricGuillemet
requested review from
bghgary
and
a balanced review from Copilot
October 15, 2026 08:19
CedricGuillemet
marked this pull request as ready for review
October 15, 2026 08:19
There was a problem hiding this comment.
🔵 Needs a closer look
Replacement cross-platform CI remains queued, and iOS runtime validation is blocked by signing.
0 open findings
What changed in this PR
Updates BabylonNative to f4d9efb, bringing upstream runtime changes into the React Native integration.
Changes:
- Updates the pinned BabylonNative revision.
- Removes obsolete
minzlinks from iOS and both Windows configurations. - Refreshes the Playground podspec checksum.
| File | Description |
|---|---|
| Package/gulpfile.js | Updates the BabylonNative revision. |
| Modules/@babylonjs/react-native/windows/BabylonReactNative/BabylonReactNative.vcxproj | Removes obsolete Windows library links. |
| Modules/@babylonjs/react-native/react-native-babylon.podspec | Removes the obsolete iOS library link. |
| Apps/Playground/ios/Podfile.lock | Refreshes the podspec checksum. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the change
Update BabylonNative from
feb0227be8890ec5dcd28c6bfc18275a98bf8d45tof4d9efbeeabcfec24105373b99e54fe147669fc1, the latest upstream master revision at preparation time, including the JsRuntimeHost update for host-controlled script loading.Remove obsolete
minzlinks from the iOS podspec and both Windows configurations; refresh the podspec checksum inPodfile.lock. The updated dependency no longer produces this library.Upstream changes.
Screenshots
Android screenshots and build/device logs captured locally; no media uploaded to this PR.
Documentation
N/A — dependency revision and native link integration only.
Testing
Android Release passed on physical Pixel 9a (Android 17). Rendering (~120 FPS displayed), animation, swipe input, engine disposal/recreation, and normal suspend/resume observed. XR showed the camera feed and
TRACKINGstatus and resumed after backgrounding; tracked physical motion was not tested. Rotation and EngineView replacement remain unverified.cd Apps/Playground/android && ./gradlew assembleRelease --console=plain --quiet— passed using Gradle 8.13; APK installed and launched ascom.microsoft.reacttestappon device5C061JEBF12501.cd Package && node_modules/.bin/gulp buildBabylonNativeSourceTree— passed.cd Package && node_modules/.bin/gulp buildTypeScript— passed during preparation.git diff --check— passed before both commits.Unsigned iOS Release passed after the
minzfix, using Xcode 26.3 and Node 22.22.3. Exact commands:All three commands passed; app includes
main.ios.jsbundle.I need help testing on iOS: connected iPhone 11 (iOS 26.6.2) runtime testing is blocked by signing. Signed build failed with
No Accounts: Add a new account in Accounts settingsandNo profiles for 'com.cedricguillemet.BRNPlaygroundUpdate' were found.No iPhone runtime checks are claimed; signing details are needed.CI: initial run passed Android source/package, TypeScript, and packaging; iOS/Windows source/package failed on obsolete
minzlinks. Removed those links infbcc414. Replacement run passed all eight jobs onfbcc4141564c82cd99a94d3b9f7c163b5ff36aac: Android, iOS, Windows, TypeScript, packaging, and all three packaged-consumer builds. CLA and GitGuardian checks also passed. Windows compilation was validated by CI, not locally on macOS.