Repository navigation
Update babylonnative 628986b - #764
Merged
CedricGuillemet merged 4 commits intoOct 12, 2026
Merged
CedricGuillemet merged 4 commits into
CedricGuillemet merged 4 commits into
Conversation
Pin CedricGuillemet/BabylonNative commit ebb8a00903cb5964bcdcaafb5a2b6d96ff8654ed from draft PR BabylonJS#17, based on upstream 628986baf4f1893618011fed6e7db360a2fbb76a. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 00e98a65-803d-48bb-8d36-da55ab233dfe
Override the module default only in the Android test app and document the version. Validated the ARM64 release build and XR tracking on Pixel 9a. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 00e98a65-803d-48bb-8d36-da55ab233dfe
Update BabylonNative to feb0227be8890ec5dcd28c6bfc18275a98bf8d45 and restore the BabylonJS archive URL after the JSI fix merged. Revalidated source preparation, TypeScript compilation, Android release build, device rendering, manually confirmed XR tracking, and suspend/resume with Playground ARCore 1.56.0. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 00e98a65-803d-48bb-8d36-da55ab233dfe
There was a problem hiding this comment.
🟢 Approval recommended
The dependency versions exist, the override follows the module’s supported mechanism, and no unresolved issues were found.
0 open findings
What changed in this PR
Updates BabylonNative and validates the Playground against ARCore 1.56.0.
Changes:
- Advances the pinned BabylonNative commit.
- Overrides and documents the Playground’s ARCore version.
| File | Description |
|---|---|
Package/gulpfile.js |
Updates BabylonNative commit pin. |
Apps/Playground/README.md |
Documents the ARCore override. |
Apps/Playground/android/build.gradle |
Sets ARCore 1.56.0 for Playground. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Keep react-native-windows at the already-locked 0.81.35 so installing the packaged BabylonReactNative artifact cannot float to npm-only 0.81.37 and restore incompatible 0.82.0 NuGet binaries. Synchronize both Playground manifests and lockfiles. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 00e98a65-803d-48bb-8d36-da55ab233dfe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
up arcore and BN commit id