Repository navigation
Move Hermes builds to nightly and gate package publication - #1945
Merged
CedricGuillemet merged 5 commits intoOct 16, 2026
Merged
CedricGuillemet merged 5 commits into
CedricGuillemet merged 5 commits into
Conversation
Keep PR and master-push CI focused on the remaining configurations. Move Windows, Linux, and Android Hermes coverage plus Windows and macOS sanitizer coverage into the existing scheduled Azure pipeline, preserving build flags, tests, diagnostics, and timeouts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6af87832-85b6-4fdb-bb9b-8d67771b1ce9
Wait for every Hermes and sanitizer configuration before running the existing Win32 RelWithDebInfo packaging job. Reject partial success and publish only the original Playground and UnitTests packages; remove all other nightly artifact uploads. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6af87832-85b6-4fdb-bb9b-8d67771b1ce9
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Cross-platform agent compatibility and matrix-dependent publication gating still need validation in an Azure pipeline run.
0 open findings
What changed in this PR
Moves Hermes and sanitizer checks from PR/push CI into the Azure nightly pipeline while preserving existing Windows packages.
Changes:
- Migrates five build configurations to nightly CI.
- Gates package publication on successful prerequisite builds and packaged tests.
- Documents scheduling, publication rules, and removal of diagnostic artifacts.
| File | Description |
|---|---|
| nightly.yml | Adds migrated jobs and publication gating; removes diagnostic uploads. |
| Documentation/ContinuousIntegration.md | Documents the CI split and nightly publication behavior. |
| .github/workflows/ci.yml | Removes Hermes and sanitizer jobs from PR/push checks. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bkaradzic-microsoft
approved these changes
Oct 15, 2026
Preserve master's sanitizer jobs, macOS Android builds, PR concurrency, Linux ccache, aggregate CI check, and V8 nightly packaging. Move the Windows, Linux, and Android Hermes configurations to nightly and remove their aggregate-check dependencies. Gate the existing Win32 packages on all nightly configurations, including generated macOS Android jobs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6af87832-85b6-4fdb-bb9b-8d67771b1ce9
CedricGuillemet
changed the title
Keep the existing Playground and UnitTests packages gated on successful completion of all nightly builds and tests. Restore Win32 screenshots and crash-dump uploads, including on failure, and retain Hermes crash-dump diagnostics. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6af87832-85b6-4fdb-bb9b-8d67771b1ce9
Preserve the existing failure-only Upload UnitTests Core Dumps task and its original artifact name and path. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6af87832-85b6-4fdb-bb9b-8d67771b1ce9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the Windows x64 D3D11, Linux Clang, and Android/Ubuntu Hermes builds from PR/push CI into the existing Azure nightly pipeline, alongside the sanitizer and macOS-hosted Android jobs already on master.
Preserve master's sanitizer build settings, V8 nightly packaging, PR concurrency, Linux compiler cache, and aggregate
ci-completecheck. Remove the moved Hermes jobs from the aggregate check's dependencies.Keep the existing Win32 x64 RelWithDebInfo Playground and UnitTests packages, with unchanged names and contents, gated on every nightly configuration and the packaged build/tests succeeding. Include all generated macOS Android jobs in that gate.
Retain diagnostic artifact publishing independently of binary package publication: Win32 sanitizer rendered pictures on success or failure, error pictures on failure, and Win32 crash dumps with associated binaries on failure, including for Hermes. Preserve the existing macOS sanitizer
Upload UnitTests Core Dumpstask, with its original failure condition, artifact name, and path.