Repository navigation
Update JsRuntimeHost for host-controlled script loading - #1940
Merged
bghgary merged 1 commit intoOct 15, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f699c13e-9c11-4caa-b86f-eb8003761f2b
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The optional loader preserves existing loading behavior, and no blocking issues were identified.
0 open findings
What changed in this PR
Updates JsRuntimeHost to include host-controlled packaged JavaScript chunk loading and native-error preservation.
Changes:
- Advances the dependency pin to include upstream PRs #259 and #264.
- Keeps existing script-loading paths unchanged; the optional chunk loader requires explicit host setup and a resolver.
| File | Description |
|---|---|
| CMakeLists.txt | Updates the pinned JsRuntimeHost revision. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bkaradzic-microsoft
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Created by Copilot on behalf of @bghgary]
Updates JsRuntimeHost to include host-controlled loading of packaged JavaScript chunks from JsRuntimeHost#259. Hosts must supply a resource resolver; this update does not enable unrestricted file or network loading.
The dependency update also includes native-error preservation across JSI host callbacks from JsRuntimeHost#264.