Repository navigation
Make admin link buttons single links and name remaining controls - #1831
Conversation
…lds, dropdowns and toggles
…d buttons, and match link-button height and ripple to PrimeReact buttons
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1831 +/- ##
==========================================
- Coverage 42.68% 42.63% -0.05%
==========================================
Files 273 273
Lines 6949 6956 +7
Branches 1386 1394 +8
==========================================
Hits 2966 2966
- Misses 3960 3967 +7
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
A second accessibility pass over the admin, after #1827. Nothing changes visually, except that the recording toggles and the rating count lose a stray pointer cursor.
Link buttons
LinkButtonrendered a PrimeReactButtoninside a routerLink: two tab stops for one control, with the name announced twice. It now renders a singleLinkwith PrimeReact's button markup: the same classes, the icon and label spans (an empty label for icon-only buttons, so heights match real buttons), and the click ripple. Its props are narrowed to what the 11 callers use.Labels and names
inputId;idtheir labels point at;MultiSelects switch fromidtoinputId.FormFieldmarks a field with an error witharia-invalidand links its message witharia-describedby. PrimeReact'sCalendarkeeps ARIA props on its wrapper, so for date fields they go to the input throughpt.Keyboard