Repository navigation
fix(leadership): recognise a stúdióvezető who holds a second role - #53
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 89 89
Lines 1961 1960 -1
Branches 501 500 -1
=========================================
- Hits 1961 1960 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The head of studio was found by an exact match on the free-text leadership label, so a label like
Stúdióvezető, tanfolyamfelelőslost the highlight and the top spot on the Vezetőség page, and was synced to Drupal as an ordinary HQ role instead of setting the leader flag.isHeadOfStudioinlib/members.tsis now the one rule, used by both the page and the Drupal sync. It accepts the title on its own or followed by a space or a comma. A hyphen does not count, becauseStúdióvezető-helyettesis the deputy.Drupal leader flag
Two existing bugs in
updateDrupalUsersat behind the same exact match:Stúdióvezető. The next status change therefore cleared the flag. It now keeps the flag Drupal reports, which was already parsed and never read."", which matched the blank HQ role a leader already holds, so the BSS tab was never posted. Whether the role changed is now judged on both fields Drupal holds, the flag and the HQ role.Side effect: giving an existing Drupal leader another stúdióvezető title (
Stúdióvezető→Stúdióvezető, tanfolyamfelelős) no longer posts, since Drupal shows the two the same way. The second role does not appear on Drupal for a leader, as before. The new website receives the full label.