Repository navigation
feat(devcontainer): enable sudo and GPU profiling permissions - #458
Merged
Merged
Conversation
Configure common-utils to enable sudo for the dev user without installing zsh or upgrading packages. Add SYS_ADMIN to the development container for Nsight Compute GPU performance-counter access when profiling as root.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both configuration changes match the stated requirements, with no unresolved findings.
0 open findings
What changed in this PR
Updates the development container to support sudo and root-based GPU profiling.
Changes:
- Configures common-utils for
devwithout installing zsh or upgrading packages. - Adds
SYS_ADMINfor Nsight Compute performance-counter access.
| File | Description |
|---|---|
| .devcontainer/devcontainer.json | Adds common-utils configuration for the development user. |
| .devcontainer/compose.devcontainer.yaml | Grants the capability needed for GPU profiling as root. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configure common-utils to enable sudo for the dev user without installing zsh or upgrading packages.
Add SYS_ADMIN to the development container for Nsight Compute GPU performance-counter access when profiling as root.