Repository navigation
refactor: *Api 인터페이스에 중복된 URL 매핑을 지우고 컨트롤러에만 둔다 - #160
Merged
Merged
Conversation
…o chore/merge-train
…nto chore/merge-train
… chore/merge-train
…o chore/merge-train
…to chore/merge-train
…chore/merge-train
…to chore/merge-train
…into chore/merge-train # Conflicts: # src/main/java/com/bcsdlab/bcsdinternalapiv2/curriculum/service/AdminCurriculumService.java
…o chore/merge-train
auth·member·ledger·reservation 등 18개 *Api 인터페이스가 컨트롤러와 같은 매핑을 한 번 더 적고 있었다. 나머지 22개처럼 인터페이스에는 OpenAPI 문서 애노테이션만 두고, 매핑은 컨트롤러에만 둔다. 구현 메서드에 매핑이 있으면 Spring은 인터페이스 쪽 매핑을 쓰지 않으므로 라우팅은 그대로다. AdminLedgerImportApi.preview만 인터페이스에 consumes=multipart가 더 있었는데, 지금도 적용되지 않던 값이라 컨트롤러 쪽(consumes 없음)을 그대로 둔다.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ff1451
marked this pull request as ready for review
October 18, 2026 13:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
*Api인터페이스에서 컨트롤러와 중복된@Get/Post/Put/Patch/DeleteMapping64개를 지웠습니다. 나머지 22개*Api처럼 인터페이스에는 OpenAPI 문서 애노테이션만 남깁니다.AdminLedgerImportApi.preview입니다. 인터페이스에만consumes = multipart/form-data가 있었는데, 구현 메서드에 매핑이 있으면 Spring은 인터페이스 매핑을 쓰지 않습니다. 그래서 지금도 적용되지 않던 값이고, 컨트롤러 쪽(consumes 없음)을 그대로 둡니다. 라우팅은 바뀌지 않습니다.머지 순서
#148~#157 머지 후 main으로 rebase하고 ready로 바꿉니다. 이 PR의 변경은 마지막 커밋 하나입니다. #159와는 파일이 겹치지 않습니다.
검증