Repository navigation
refactor: 쓰이지 않는 코드를 지운다 - #149
Merged
Merged
Conversation
- 참조가 없는 에러 상수 INVALID_GOOGLE_FORM_URL, INVALID_PHOTO - 호출부가 없는 ReservationGroup.includesWeekday(), SoftDeletableEntity.isDeleted() (isDeleted는 @SQLRestriction 때문에 조회된 엔티티에서 항상 false였다) - 아무도 주입받지 않는 S3Client 빈과 테스트의 목(같은 SDK의 S3Presigner는 계속 쓴다) - 대입만 하고 쓰지 않는 지역 변수 3개(게임 존재 확인 호출은 남긴다) - 존재하지 않는 캐시를 무효화한다는 주석
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 33 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
동작을 바꾸지 않는 정리. 모두
src/main·src/test전체에서 참조가 없음을 확인했다.HomeExceptionType.INVALID_GOOGLE_FORM_URL,MemberExceptionType.INVALID_PHOTOReservationGroup.includesWeekday()SoftDeletableEntity.isDeleted()@SQLRestriction때문에 조회된 엔티티에서는 항상false였다S3Config.s3Client()빈 + 장부 테스트의@MockitoBean S3ClientS3Presigner는 계속 쓴다Game game = findGameOrThrow(...)지역 변수 3개AdminGameService의 "목록 캐시 무효화" 주석테스트
./gradlew test: 535건 중 534 통과, 1 스킵.