Repository navigation
Fix flaky Blob tag test by moving search coverage to playback - #7483
Open
JinmingHu (Jinming-Hu) wants to merge 1 commit into
Open
JinmingHu (Jinming-Hu) wants to merge 1 commit into
JinmingHu (Jinming-Hu) wants to merge 1 commit into
Conversation
Keep synchronous tag operations covered in live and playback modes, while moving eventually consistent FindBlobsByTags coverage to a playback-only test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test split preserves coverage, uses existing LIVE-skip behavior, and includes matching recordings.
No open issues 🎉
What changed in this PR
Separates synchronous Blob tag tests from eventually consistent tag-search tests to reduce LIVE CI flakes.
Changes:
- Renames synchronous coverage to
GetSetTags. - Moves search and paging coverage into a RECORD/PLAYBACK-only test.
- Updates the Storage assets tag for both recordings.
| File | Description |
|---|---|
| sdk/storage/azure-storage-blobs/test/ut/blob_container_client_test.cpp | Splits synchronous tag operations from tag-search coverage. |
| sdk/storage/assets.json | References updated test recordings. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.
Description
Split the Blob tag test so synchronous tag operations remain covered in LIVE and PLAYBACK, while
FindBlobsByTagspaging runs only in RECORD/PLAYBACK. Blob Index updates are eventually consistent, so requiring search results to appear within the LIVE test deadline was testing service propagation timing and caused recurring CI flakes.BlobContainerClientTest.TagstoBlobContainerClientTest.GetSetTags.BlobContainerClientTest.ListBlobsByTags_PLAYBACKONLY_for container- and service-level search and paging coverage.GetSetTagstest already covers synchronous operations and Data Lake exposes no tag-search API.Doxygen, changelog, related issue, and external documentation updates are not applicable to this test-only change. There are no breaking changes.
Validation
cmake.exe --build C:\wd\azure-sdk-for-cpp\build --config Release --target azure-storage-blobs-testazure-storage-blobs-test.exe --gtest_filter=BlobContainerClientTest.GetSetTags:BlobContainerClientTest.ListBlobsByTags_PLAYBACKONLY_withAZURE_TEST_MODE=PLAYBACKGetSetTagsin LIVE mode, withListBlobsByTags_PLAYBACKONLY_skipped in LIVE as intended.