Repository navigation
{Network} az network ddos-custom-policy: Support DDoS mitigation rules with API version 2026-03-01 - #34218
Merged
Ethan Yang (necusjz) merged 1 commit intoOct 14, 2026
Conversation
microsoft-github-policy-service
Bot
requested review from
Yu Chen (jsntcy),
Ethan Yang (necusjz) and
Yong Zhang (yonzhan)
October 13, 2026 02:31
Collaborator
|
Network |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The generated schemas, custom merge behavior, API-version updates, and comprehensive scenario coverage are consistent and complete.
0 open findings
What changed in this PR
Adds Network API 2026-03-01 support for DDoS custom-policy mitigation rules.
Changes:
- Adds mitigation-rule create, update, show, and list support.
- Preserves existing rules during repeated creates and enables subscription-scoped listing.
- Adds scenario coverage and updates recordings for the new API version.
| File | Description |
|---|---|
_help.py |
Adds mitigation-rule example. |
_params.py |
Exposes generated mitigation-rule parsing. |
_template_builder.py |
Builds mitigation-only policies. |
custom.py |
Materializes and merges mitigation rules. |
operations/ddos_custom_policy.py |
Converts and merges rule collections. |
aaz/.../_create.py |
Adds mitigation-rule create schema. |
aaz/.../_update.py |
Adds mitigation-rule update support. |
aaz/.../_show.py |
Returns mitigation rules. |
aaz/.../_list.py |
Adds mitigation rules and subscription listing. |
aaz/.../_delete.py |
Updates the API version. |
aaz/.../_wait.py |
Updates API and response schemas. |
test_network_commands.py |
Adds end-to-end mitigation-rule coverage. |
test_ddos_custom_policy_mitigation_rules.yaml |
Records the new scenarios. |
test_ddos_custom_policy.yaml |
Updates playback API versions. |
test_ddos_custom_policy_attach_to_public_ip.yaml |
Updates playback API versions. |
test_ddos_custom_policy_attach_to_lb_fip.yaml |
Updates playback API versions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Ethan Yang (necusjz)
approved these changes
Oct 14, 2026
az network ddos-custom-policy: Support DDoS mitigation rules with API version 2026-03-01az network ddos-custom-policy: Support DDoS mitigation rules with API version 2026-03-01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation —⚠️ Review suggested
Related command
az network ddos-custom-policy createaz network ddos-custom-policy updateaz network ddos-custom-policy showaz network ddos-custom-policy listDescription
Resolves #34215.
Adds DDoS Custom Policy mitigation-rule support introduced in Network API
2026-03-01.az network ddos-custom-policyfrom API version2025-07-01to2026-03-01(AAZ: faet: upgrade ddos custom policy api version aaz#1118).create: add--mitigation-rules. The argument reuses the generated AAZ argument, so shorthand syntax, JSON,@fileand??help are supported. Re-runningcreatemerges detection and mitigation rules by name instead of dropping existing mitigation rules.create: no longer injects an empty detection rule when no detection-rule arguments are given, which enables mitigation-only policies.update:--mitigation-rules(from regenerated AAZ) replaces the whole collection; generic--set/--removecan be used for partial changes.show/list: returnmitigationRules.listnow also supports listing at subscription scope when--resource-groupis omitted (from regenerated AAZ).api-versionforddosCustomPoliciesrequests to2026-03-01.Notes:
mitigationRulesis currently supported incentraluseuaponly; other regions such aseastusreject the property, so the new scenario test runs incentraluseuap.Testing Guide
Tests (playback):
test_ddos_custom_policy_mitigation_rules(new, recorded live incentraluseuap): covers all E2E scenarios listed in Add DDoS Custom Policy mitigation-rule support to Azure CLI #34215 — passedtest_ddos_custom_policy— passedtest_ddos_custom_policy_attach_to_lb_fip— passedtest_ddos_custom_policy_attach_to_public_ip— passedazdev linter network— passedHistory Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.