Repository navigation
[Containerapp] az containerapp job execution list: Fix incomplete paginated results - #34209
Open
Korede (kokelowo) wants to merge 3 commits into
Open
Korede (kokelowo) wants to merge 3 commits into
Korede (kokelowo) wants to merge 3 commits into
Conversation
Follow ARM continuation URLs and return complete execution history. Add an optional page-size argument with regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 445d57df-fd66-4c9d-b6a0-ee9c14ca213d
Korede (kokelowo)
requested review from
a team,
Greedygre (Greedygre),
Zunli Hu (Juliehzl) and
Hong Wang (howang-ms)
as code owners
October 9, 2026 20:38
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
ZelinWang (wangzelin007) and
Yong Zhang (yonzhan)
October 9, 2026 20:38
Contributor
|
Thank you for your contribution Korede (@kokelowo)! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The introduced pageSize query parameter is absent from the selected ARM API contract.
1 open finding
What changed in this PR
Fixes Container App Job execution pagination while preserving output shape and continuation behavior.
Changes:
- Aggregates all ARM execution pages securely.
- Adds pagination tests and
--page-size. - Updates command help.
| File | Description |
|---|---|
_clients.py |
Implements pagination and continuation validation. |
custom.py |
Forwards and validates page size. |
_params.py |
Defines --page-size. |
_help.py |
Documents pagination usage. |
test_containerappjob_execution_pagination.py |
Tests pagination and failures. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Collaborator
|
Please fix CI issues |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 445d57df-fd66-4c9d-b6a0-ee9c14ca213d
az containerapp job execution list: Fix incomplete paginated results
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Keep automatic ARM continuation handling without exposing an undocumented query parameter. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 445d57df-fd66-4c9d-b6a0-ee9c14ca213d
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🤖 PR Validation —⚠️ Review suggested
Related command
az containerapp job execution listDescription
The command currently returns only the first page of execution history when ARM supplies a
nextLink.This change:
nextLinkand aggregates executions in server-provided order, including when an intermediate page is empty.No new flags or API-version changes are included.
Testing Guide
With repository source packages on
PYTHONPATH, the following command passed all 12 tests, covering pagination, error propagation, existing unit tests, and two recorded execution scenarios:Additional checks passed:
Both help commands omit the removed flag, and an argument-parsing check confirmed that the removed flag is rejected before an ARM request is made.
Reviewer usage example with placeholder resource names:
On a job with multiple execution pages, the command should return all executions, not just one.
History Notes
[Containerapp]
az containerapp job execution list: Follow ARM pagination to return all executionsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.