Repository navigation
[Containerapp] az containerapp up: Validate registry server - #10508
Open
Vini Soto (vinisoto) wants to merge 3 commits into
Open
Vini Soto (vinisoto) wants to merge 3 commits into
Vini Soto (vinisoto) wants to merge 3 commits into
Conversation
…getting ACR credentials Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c57e2576-8a31-49ad-8ff6-23f46a65af23
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c57e2576-8a31-49ad-8ff6-23f46a65af23
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
ZelinWang (wangzelin007) and
Yong Zhang (yonzhan)
October 22, 2026 18:34
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Raw-string validation breaks credential lookup for URL-form ACR servers previously handled by the existing parsing logic.
1 open issue
What changed in this PR
This PR adds active-cloud ACR suffix validation before az containerapp up retrieves registry credentials.
Changes:
- Validates registry servers and derives the ACR name before credential lookup.
- Adds unit tests for credential combinations, cloud suffixes, and existing registry guards.
- Bumps the extension version to
1.3.0b6and records the change.
| File | Description |
|---|---|
src/containerapp/setup.py |
Bumps the extension version. |
src/containerapp/HISTORY.rst |
Documents registry validation. |
src/containerapp/azext_containerapp/tests/latest/test_containerapp_up_registry_unit.py |
Adds focused registry-validation tests. |
src/containerapp/azext_containerapp/_up_utils.py |
Validates registry servers before retrieving ACR credentials. |
Review effort: Balanced
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c57e2576-8a31-49ad-8ff6-23f46a65af23
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🤖 PR Validation — ️✔️ All clear
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp up --repoValidate the registry server against the active cloud's ACR suffix before retrieving ACR credentials
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)Validation results:
azdev style containerapp— passed; pylint and flake8.azdev linter containerapp— passed.python scripts/ci/test_index.py -q— passed; 9 tests run, 2 skipped.azdev test test_containerapp_up_registry_unit --series --pytest-args --disable-socket— passed; 5 tests and 37 subtests.azdev test containerapp --series --pytest-args --disable-socket— failed during collection becauseScenarioTest.__init__does not acceptrandom_config_dirin the existingtest_containerapp_arc_commands.pytests.For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.Updated
setup.pyandHISTORY.rst;src/index.jsonis unchanged.