Skip to content

[Containerapp] az containerapp up: Validate registry server - #10508

Open
Vini Soto (vinisoto) wants to merge 3 commits into
Azure:mainfrom
vinisoto:vsoto-microsoft-registry-server-validation
Open

Vini Soto (vinisoto) wants to merge 3 commits into
Azure:mainfrom
vinisoto:vsoto-microsoft-registry-server-validation

Conversation

@vinisoto

@vinisoto Vini Soto (vinisoto) commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

🤖 PR Validation — ️✔️ All clear

Breaking Changes
️✔️ None

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp up --repo

Validate the registry server against the active cloud's ACR suffix before retrieving ACR credentials

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
  • My extension version conforms to the Extension version schema

Validation results:

  • azdev style containerapp — passed; pylint and flake8.
  • azdev linter containerapp — passed.
  • python scripts/ci/test_index.py -q — passed; 9 tests run, 2 skipped.
  • azdev test test_containerapp_up_registry_unit --series --pytest-args --disable-socket — passed; 5 tests and 37 subtests.
  • azdev test containerapp --series --pytest-args --disable-socket — failed during collection because ScenarioTest.__init__ does not accept random_config_dir in the existing test_containerapp_arc_commands.py tests.

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Updated setup.py and HISTORY.rst; src/index.json is unchanged.

Vini Soto (from Dev Box) and others added 2 commits October 22, 2026 10:14
…getting ACR credentials

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: c57e2576-8a31-49ad-8ff6-23f46a65af23
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: c57e2576-8a31-49ad-8ff6-23f46a65af23
Copilot AI balanced review requested due to automatic review settings October 22, 2026 18:34
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Raw-string validation breaks credential lookup for URL-form ACR servers previously handled by the existing parsing logic.

1 open issue
What changed in this PR

This PR adds active-cloud ACR suffix validation before az containerapp up retrieves registry credentials.

Changes:

  • Validates registry servers and derives the ACR name before credential lookup.
  • Adds unit tests for credential combinations, cloud suffixes, and existing registry guards.
  • Bumps the extension version to 1.3.0b6 and records the change.
File Description
src/​containerapp/​setup.py Bumps the extension version.
src/​containerapp/​HISTORY.rst Documents registry validation.
src/​containerapp/​azext_containerapp/​tests/​latest/​test_containerapp_up_registry_unit.py Adds focused registry-validation tests.
src/​containerapp/​azext_containerapp/​_up_utils.py Validates registry servers before retrieving ACR credentials.

Review effort: Balanced

Comment thread src/containerapp/azext_containerapp/_up_utils.py Outdated
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@x-engineering-agent
x-engineering-agent Bot requested a review from a team October 22, 2026 18:42
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: c57e2576-8a31-49ad-8ff6-23f46a65af23
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants