Repository navigation
{confcom} Add single-string exec command arrays alongside argv for Windows - #10506
Merged
Merged
Conversation
…icies Retain exec argument arrays and additionally emit Windows command-line strings to work around hcsshim passing CommandLine as a single argument. Apply this to Windows exec commands, probes, and lifecycle hooks. Preserve Linux behavior and deduplicate identical entries. Add regression coverage for quoting, deduplication, and exact argument matching. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution Takuro Sato (@takuro-sato)! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to Windows serialization, includes focused regression coverage, and has no identified blocking issues.
No open issues 🎉
What changed in this PR
Updates confcom’s Windows exec policy generation to accommodate hcsshim passing a command line as one argument, while retaining argument arrays and preserving Linux behavior.
Changes:
- Adds deduplicated Windows command-line representations for exec commands, probes, and lifecycle hooks.
- Adds regression coverage for quoting, deduplication, source preservation, and exact argument matching.
- Bumps confcom to version 2.4.1 and documents the workaround.
| File | Description |
|---|---|
src/confcom/setup.py |
Bumps the extension version to 2.4.1. |
src/confcom/HISTORY.rst |
Records the Windows exec workaround. |
src/confcom/azext_confcom/tests/latest/test_confcom_input_fields.py |
Adds Windows serialization and Linux preservation tests. |
src/confcom/azext_confcom/data/customer_rego_policy_windows.txt |
Adds a comment explaining the dual command representations. |
src/confcom/azext_confcom/container.py |
Emits deduplicated Windows command-line entries alongside argument arrays. |
Review effort: Balanced
KenGordon
approved these changes
Oct 22, 2026
KenGordon
left a comment
KenGordon
left a comment
There was a problem hiding this comment.
To the extensions team, please can you expedite this release. I own this product.
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
JaysonTaiMicrosoft
changed the title
JaysonTaiMicrosoft
approved these changes
Oct 23, 2026
Collaborator
|
[Release] Update index.json for extension [ confcom ] : https://dev.azure.com/msazure/One/_build/results?buildId=187251524&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Retain exec argument arrays and additionally emit Windows command-line strings to work around hcsshim passing CommandLine as a single argument.
Apply this to Windows exec commands, probes, and lifecycle hooks. Preserve Linux behavior and deduplicate identical entries.
Add regression coverage for quoting, deduplication, and exact argument matching.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.