Skip to content

{Misc} Remove individual reviewers for PR - #10504

Merged
Yu Chen (jsntcy) merged 1 commit into
Azure:mainfrom
jsntcy:ychenu/remove-individual-reviewers
Oct 23, 2026
Merged

Yu Chen (jsntcy) merged 1 commit into
Azure:mainfrom
jsntcy:ychenu/remove-individual-reviewers

Conversation

@jsntcy

@jsntcy Yu Chen (jsntcy) commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

🤖 PR Validation — ️✔️ All clear

Breaking Changes
️✔️ None

With the transition to a squad-based Scrum Master model, assigning specific engineers/squads as reviewers is no longer required and we just assign the squad acting as scrum master as the reviewer.

Copilot AI balanced review requested due to automatic review settings October 22, 2026 01:05
@jsntcy Yu Chen (jsntcy) added the Request X Engineering Agent Ask the agent to triage this issue or review this PR label Oct 22, 2026
@x-engineering-agent

x-engineering-agent Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

X Engineering Agent Pull request review: Comments

Yu Chen (@jsntcy) One scope-consistency finding remains; this is a non-approving comment.

Scope consistency

Keep the reviewer removal durable — .github/policies/resourceManagement.yml:3634. The Machine Learning PR rule now retains component labels but no reviewers. The weekly pipeline (.azure-pipelines/sync-squad-mapping.yml:9-13,47) still invokes ParseSquadMappingList.ps1, which reads this policy at lines 390-398. For mapped components, lines 303-321 resolve the squad and identify PR rules; lines 339-353 insert a team requestReview using the last label as an anchor even when no reviewers remain. Lines 377-404 apply and write the result, and pipeline lines 53-105 can propose a PR restoring those requests. This confirms the pending Copilot feedback.

Update the generator to preserve squad labels without recreating component-squad review requests under the described Scrum Master model. If only individual removal is intended, retain team requests instead. Verify with the changed Machine Learning rule and a fixed squad mapping that transformation preserves labels, adds no removed team requests, and is idempotent. This verification was not run.

Upstream CI

27 checks completed; 26 passed, 0 failed, 0 pending. No upstream failures to classify. These are upstream results, not Agent test execution.

Test validation
  • Agent live test: Not run; this is a review-only PR. Check author-provided test evidence and upstream CI separately.
  • Regression coverage: Not applicable to the changed files.
⚖️ Risk assessment — 2/100 · Low

The Low rating reflects the detected change scope with no elevated security, reliability, customer, operational, dependency, sovereign-cloud, generated-output, or cross-component signal.

  • Change scope: 1 changed file, 407 changed lines (+11 / -396), including 0 production files.
  • Affected components: No production component was identified.
  • Risk drivers: No elevated risk signal was detected.
  • Regression evidence: No production-code regression-test signal applies.
  • Confidence: Low because no production changed-line evidence was available.
  • Required review: No additional owning-squad review signal was detected.

X Engineering Agent · Reviewer · react 👍 / 👎 to train the agent

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The weekly squad-mapping generator remains inconsistent with the policy and can propose restoring removed team review requests.

1 open issue
What changed in this PR

Updates PR automation for the squad-based Scrum Master model by removing many hard-coded reviewer and assignee actions.

Changes:

  • Removes individual and squad review requests across service-specific rules.
  • Removes selected assignee actions and personal mentions from review reminders.
  • Preserves most service and squad labels.
File Description
.github/​policies/​resourceManagement.yml Removes reviewer routing and simplifies selected review notifications.

Review effort: Balanced

- assignTo:
users:
- wangzelin007
description: '[machine learning] Auto assign labels and reviewers based on PR title/description.'
@yonzhan

Copy link
Copy Markdown
Collaborator

Misc

@jsntcy
Yu Chen (jsntcy) merged commit 74a4140 into Azure:main Oct 23, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Request X Engineering Agent Ask the agent to triage this issue or review this PR X Engineering Agent Reviewed Agent reviewed this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants