Repository navigation
{AKS} az aks create: add --enable-quick-attach-detach - #10502
Open
Jenniferyingni wants to merge 2 commits into
Open
Jenniferyingni wants to merge 2 commits into
Jenniferyingni wants to merge 2 commits into
Conversation
API version 2026-08-02-preview adds storageProfile.diskCSIDriver.quickAttachDetach.enabled, which turns on Quick Attach Detach for the AzureDisk CSI driver. The SDK bump in Azure#10491 picked up the model; this exposes it on create. --enable-quick-attach-detach (preview) sets the nested property and also sets diskCSIDriver.enabled=true, since QAD requires the disk driver. It is rejected client-side together with --disable-disk-driver. Kubernetes version, OIDC issuer and Windows pool requirements are left to the RP, which returns specific errors for each.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in the focused command wiring, validation, or profile construction, with targeted unit coverage added but not executed.
No open issues 🎉
What changed in this PR
Adds the preview --enable-quick-attach-detach option to az aks create, exposing the AzureDisk CSI Driver feature through the AKS extension.
Changes:
- Enables Quick Attach Detach and the disk driver together, rejecting use with
--disable-disk-driver. - Adds unit coverage for defaults, enablement, and conflicting options.
- Documents feature requirements and adds the option-length lint exclusion.
| File | Description |
|---|---|
src/aks-preview/linter_exclusions.yml |
Allows the new option’s length. |
src/aks-preview/HISTORY.rst |
Records the new preview option. |
src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py |
Tests enablement, defaults, and conflict validation. |
src/aks-preview/azext_aks_preview/managed_cluster_decorator.py |
Validates the option and builds the nested storage profile. |
src/aks-preview/azext_aks_preview/custom.py |
Adds the option to the create command signature. |
src/aks-preview/azext_aks_preview/_params.py |
Registers the preview CLI flag. |
src/aks-preview/azext_aks_preview/_help.py |
Describes the feature and its requirements. |
Review effort: Balanced
|
Hi Jenniferyingni, |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation —⚠️ Review suggested
API version 2026-08-02-preview adds
storageProfile.diskCSIDriver.quickAttachDetach.enabled, which turns on Quick Attach Detach for the AzureDisk CSI driver.
enable-quick-attach-detach (preview) sets the nested property and also sets diskCSIDriver.enabled=true, since QAD requires the disk driver. It is rejected client-side together with --disable-disk-driver.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create --enable-quick-attach-detach
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.