Repository navigation
{AKS} az aks create: add --enable-quick-attach-detach - #10501
Closed
Jenniferyingni wants to merge 1 commit into
Closed
Jenniferyingni wants to merge 1 commit into
Jenniferyingni wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes match the create-only scope, include targeted regression coverage, and have no identified blocking defects.
No open issues 🎉
What changed in this PR
Adds preview support for az aks create --enable-quick-attach-detach, exposing the AzureDisk CSI capability available in the SDK introduced by #10491. az aks update remains unchanged.
Changes:
- Enables Quick Attach Detach and the disk driver together, rejecting use with
--disable-disk-driver. - Documents prerequisites, which remain validated by the service.
- Adds unit coverage, release notes, and a flag-length linter exclusion.
| File | Description |
|---|---|
| src/aks-preview/linter_exclusions.yml | Exempts the new flag from the option-length rule. |
| src/aks-preview/HISTORY.rst | Records the new create option. |
| src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py | Tests defaults, enablement, and conflicting flags. |
| src/aks-preview/azext_aks_preview/managed_cluster_decorator.py | Validates the flag and constructs the nested storage profile. |
| src/aks-preview/azext_aks_preview/custom.py | Adds the create-command parameter. |
| src/aks-preview/azext_aks_preview/_params.py | Registers the preview flag. |
| src/aks-preview/azext_aks_preview/_help.py | Documents the feature and prerequisites. |
Review effort: Balanced
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
Hi Jenniferyingni, |
API version 2026-08-02-preview adds storageProfile.diskCSIDriver.quickAttachDetach.enabled, which turns on Quick Attach Detach for the AzureDisk CSI driver. The SDK bump in Azure#10491 picked up the model; this exposes it on create. --enable-quick-attach-detach (preview) sets the nested property and also sets diskCSIDriver.enabled=true, since QAD requires the disk driver. It is rejected client-side together with --disable-disk-driver. Kubernetes version, OIDC issuer and Windows pool requirements are left to the RP, which returns specific errors for each.
Jenniferyingni
force-pushed
the
aks/enable-quick-attach-detach
branch
from
October 21, 2026 23:42
b6563c0 to
2dc5d02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API version
2026-08-02-previewaddsstorageProfile.diskCSIDriver.quickAttachDetach.enabled, which turns on Quick Attach Detach (QAD) for the AzureDisk CSI driver (aka.ms/aks/qad). #10491 bumped the vendored SDK to that version; this PR exposes the property onaz aks create.--enable-quick-attach-detachonaz aks create.diskCSIDriver.enabledis set totrueas well, because QAD requires the disk driver, so--enable-disk-driveris not needed alongside it.--disable-disk-driverraisesMutuallyExclusiveArgumentError.az aks updateis intentionally unchanged.Testing
test_managed_cluster_decorator.py(test_get_disk_driver,test_get_enable_quick_attach_detach); the full module passes (438 tests).--debug. The PUT usedapi-version=2026-08-02-previewwith the body above, and the RP's QAD validator responded (InvalidClusterVersion: Quick Attach/Detach requires k8s version >= 1.37.0when run with-k 1.34), confirming the property is serialized and honored.🤖 Generated with Claude Code
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create --enable-quick-attach-detachGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired) — not run, azdev unavailable in this environment; relying on CIpython scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.