Skip to content

{Misc} Rename CODEOWNERS to OWNERS - #10496

Merged
Yu Chen (jsntcy) merged 2 commits into
Azure:mainfrom
jsntcy:ychenu/rename-codeowners
Oct 21, 2026
Merged

Yu Chen (jsntcy) merged 2 commits into
Azure:mainfrom
jsntcy:ychenu/rename-codeowners

Conversation

@jsntcy

@jsntcy Yu Chen (jsntcy) commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

🤖 PR Validation — ️✔️ All clear

Breaking Changes
️✔️ None

Why do we rename CODEOWNERS to OWNERS?

As we move to a squad-based Scrum Master model, CODEOWNERS has become a bottleneck for code review productivity.

After we renamed CODEOWNERS to OWNERS, GitHub will then treat it (OWNERS) as a normal file, so we can keep the ownership information without triggering the built-in CODEOWNERS behavior (Merging will be blocked by owner's approval).

This also prevents GitHub from automatically requesting reviews from the listed owners, which no longer matches our process. Instead, the squad, acting as the Scrum Master, should be assigned as the reviewer.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The ownership verifier still opens the deleted file and will fail when run.

1 open issue
What changed in this PR

Moves ownership information to a normal file to support squad-based reviews without GitHub’s built-in CODEOWNERS behavior.

Changes:

  • Replaces .github/CODEOWNERS with .github/OWNERS.
  • Updates many ownership entries to squad teams.
File Description
.github/​OWNERS Retains ownership information with updated squad assignments.
.github/​CODEOWNERS Removes GitHub’s recognized ownership file.

Review effort: Balanced

Comment thread .github/OWNERS
@@ -0,0 +1,349 @@
# See for instructions on this file https://help.github.com/articles/about-codeowners/

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Azure/x-engineering-agent Update verifier and README to use .github/OWNERS
The rename leaves scripts/ci/verify_codeowners.py:14–20 opening .github/CODEOWNERS, so running the verifier raises FileNotFoundError instead of checking ownership. Update it to read .github/OWNERS. Also update README.md:32, which still tells contributors to add owners to the old path; following that instruction could recreate the file and restore GitHub's automatic review behavior.

@yonzhan

Copy link
Copy Markdown
Collaborator

Misc

@jsntcy Yu Chen (jsntcy) added the Request X Engineering Agent Ask the agent to triage this issue or review this PR label Oct 21, 2026
@x-engineering-agent

x-engineering-agent Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

X Engineering Agent Report

Review — Comments

Yu Chen (@jsntcy)

Copilot's stale-path feedback is addressed: the verifier and README now reference .github/OWNERS.

P2 — Restore omitted ownership entries. .github/OWNERS:11–17 drops /src/aem/ and /src/alias/ from the former ownership list, but both directories still exist. The verifier reads OWNERS at scripts/ci/verify_codeowners.py:14,20–22, detects those missing entries at lines 26–29, and exits 1 at line 38. Restore both mappings with appropriate owners, then run the existing verifier to confirm they are no longer reported missing.

The supplied upstream CI snapshot reports no failures; I did not rerun CI, execute the verifier, or verify GitHub review-routing behavior.

Test validation
  • Agent live test: Not run; this is a review-only PR. Check author-provided test evidence and upstream CI separately.
  • Regression coverage: Not applicable to the changed files.
Risk assessment — 3/100 · Low

The Low rating reflects the detected change scope with no elevated security, reliability, customer, operational, dependency, sovereign-cloud, generated-output, or cross-component signal.

  • Change scope: 4 changed files, 706 changed lines (+351 / -355), including 0 production files.
  • Affected components: No production component was identified.
  • Risk drivers: No elevated risk signal was detected.
  • Regression evidence: No production-code regression-test signal applies.
  • Confidence: Low because no production changed-line evidence was available.
  • Required review: No additional owning-squad review signal was detected.

Posted by x-engineering-agent (Reviewer)

@jsntcy
Yu Chen (jsntcy) merged commit bdc9dfb into Azure:main Oct 21, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Request X Engineering Agent Ask the agent to triage this issue or review this PR X Engineering Agent Reviewed Agent reviewed this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants