Repository navigation
test - #10492
Closed
Charlie Li (chengliangli0918) wants to merge 1 commit into
Closed
test#10492Charlie Li (chengliangli0918) wants to merge 1 commit into
Charlie Li (chengliangli0918) wants to merge 1 commit into
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Conversion can alter unrelated cluster credentials and cause repeat credential retrievals to fail with merge conflicts.
2 open issues
What changed in this PR
Adds automatic conversion from kubelogin device-code authentication to Azure CLI authentication for AI Manager and namespace credential retrieval.
Changes:
- Detects device-code kubeconfigs, locates kubelogin, and invokes conversion after merging credentials.
- Warns when kubelogin is unavailable or conversion fails.
- Bumps the extension to
2.0.1b3and documents the behavior.
| File | Description |
|---|---|
src/aimanager/setup.py |
Updates the extension version to 2.0.1b3. |
src/aimanager/HISTORY.rst |
Documents automatic authentication conversion. |
src/aimanager/azext_aimanager/custom.py |
Invokes conversion after credential merging. |
src/aimanager/azext_aimanager/_helpers.py |
Adds executable discovery, authentication detection, and conversion helpers. |
Review effort: Balanced
Comment on lines
+113
to
+116
| subprocess.run( | ||
| [kubelogin_path, "convert-kubeconfig", "-l", "azurecli", "--kubeconfig", path], | ||
| check=True, | ||
| ) |
| try: | ||
| kubeconfig = credential_results.kubeconfigs[0].value.decode(encoding='UTF-8') | ||
| print_or_merge_credentials(path, kubeconfig, overwrite_existing, context_name) | ||
| convert_kubelogin_devicecode(path, kubeconfig) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.