Repository navigation
Fix/ssh token output regression - #10490
Open
lavakumarrepala wants to merge 5 commits into
Open
lavakumarrepala wants to merge 5 commits into
lavakumarrepala wants to merge 5 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 05bf1e5b-fbcf-415a-ad7f-90ba2d884fda
Document the stdout transport constraint and guard script startup so connector helpers can be tested without opening an SSH connection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5f5091db-6c71-4232-9542-99341594a5fd
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
/azp run |
1 similar comment
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
1 similar comment
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
Hi lavakumarrepala, |
Stub the unused optional WebSocket transport in CLI-output tests so they run without the on-demand SSH dependency. Add the customer-visible change to HISTORY.rst. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5f5091db-6c71-4232-9542-99341594a5fd
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow fix preserves token retrieval and error handling, with targeted regression coverage and no unresolved findings.
No open issues 🎉
What changed in this PR
Prevents formatted access-token output from entering the SSH transport or verbose SSH logs for Azure ML SSH connections.
Changes:
- Captures CLI output in memory while preserving result and error handling.
- Adds regression tests and an import-safe script entry point.
- Documents the fix in release history.
| File | Description |
|---|---|
| src/machinelearningservices/HISTORY.rst | Documents the token-output fix. |
| src/machinelearningservices/azext_mlv2/tests/latest/test_ssh_connector.py | Tests output isolation and result/error handling. |
| src/machinelearningservices/azext_mlv2/manual/custom/_ssh_connector.py | Captures formatted output and guards script execution. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.