Repository navigation
[fleet] Preserve resolved kubelogin executable path - #10489
Open
Wei Weng (weng271190436) wants to merge 3 commits into
Open
Wei Weng (weng271190436) wants to merge 3 commits into
Wei Weng (weng271190436) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix has matching regression assertions and no identified blocking issues.
No open issues 🎉
What changed in this PR
Preserves the resolved kubelogin executable path when converting Fleet kubeconfigs.
Changes:
- Passes the path returned by
shutil.whichdirectly to the subprocess. - Updates regression assertions for paths containing spaces and stdout handling.
- Adds a pending release note.
| File | Description |
|---|---|
| src/fleet/HISTORY.rst | Documents the executable-path fix. |
| src/fleet/azext_fleet/tests/latest/test_kubelogin_conversion.py | Strengthens path-selection and stdout assertions. |
| src/fleet/azext_fleet/custom.py | Executes the resolved kubelogin path. |
Review effort: Balanced
Member
|
/azp run |
1 similar comment
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
1 similar comment
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
Hi Wei Weng (@weng271190436), |
Update only AKS request URI versions from 2026-05-01 to 2026-07-01 for playback with azure-mgmt-containerservice 41.7.0. Recorded payloads are unchanged; this is not a live re-recording. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Describe the credential conversion fix in customer-facing release notes and align package and extension metadata versions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
FumingZhang
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az fleet
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.