[cloudhsm] Support API 2025-12-01-preview and v2 SKUs by neerjagangwar · Pull Request #10488 · Azure/azure-cli-extensions

neerjagangwar · 2026-10-19T15:08:38Z

🤖 PR Validation — ⚠️ Review suggested

Breaking Changes
⚠️ None

⚠️Azure CLI Extensions Breaking Change Test

⚠️cloudhsm

rule cmd_name rule_message suggest_message

⚠️ 1010 - ParaPropUpdate cloudhsm create cmd cloudhsm create update parameter sku: updated property choices from ['Standard B10', 'Standard_B1'] to ['Standard B10', 'Standard_B1', 'Standard_B10v2', 'Standard_B15v2', 'Standard_B1v2', 'Standard_B20v2', 'Standard_B5v2']

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az cloudhsm create, az cloudhsm update, az cloudhsm show, az cloudhsm list, az cloudhsm delete, az cloudhsm backup start, az cloudhsm restore start

Description

Moves the cloudhsm extension to API version 2025-12-01-preview (swagger tag package-2025-12-01-preview). For Cloud HSM, the only change in this API version is the new cluster SKUs:

Standard_B1v2
Standard_B5v2
Standard_B10v2
Standard_B15v2
Standard_B20v2

Changes:

Regenerated the aaz commands with aaz-dev-tools against 2025-12-01-preview. --sku now accepts all 7 SKUs.
backup show and restore show are still unregistered, same as before. The generator's new wait command was not added.
Bumped the version to 1.0.0b2, updated HISTORY.rst and the README SKU list. minCliCoreVersion is now 2.75.0, as set by the generator.
Updated the api-version in the test recordings.

AAZ PR: Azure/aaz#1133

Testing

az cloudhsm create -h lists all 7 SKUs with the extension installed locally (azure-cli 2.91.0).
Playback tests: test_backup_restore and test_create_list_and_get_cloudHsm pass in CI (azdev test azext_cloudhsm, 2 passed).

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
My extension version conforms to the Extension version schema

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Regenerate the cloudhsm extension against API version 2025-12-01-preview so az cloudhsm create accepts the Standard_B1v2, Standard_B5v2, Standard_B10v2, Standard_B15v2 and Standard_B20v2 SKUs. Bump to 1.0.0b2. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8c1d28bd-31c4-410c-a15a-97876904c51c

azure-pipelines · 2026-10-19T15:09:04Z

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

Aditya Pujara (a0x1ab) · 2026-10-19T15:14:48Z

/azp run

azure-pipelines · 2026-10-19T15:15:02Z

Azure Pipelines: Successfully started running 2 pipeline(s).

Copilot

🟢 Approval recommended

The narrowly scoped API migration, SKU additions, and supporting updates are consistent, with no blocking issues identified.

No open issues 🎉

What changed in this PR

Updates the CloudHSM extension to API 2025-12-01-preview, enabling five v2 SKUs while preserving existing command availability.

Changes:

Regenerates commands with the preview API and expanded SKU choices.
Releases 1.0.0b2, requiring Azure CLI 2.75.0.
Updates SKU documentation and playback recording API versions.

File	Description
`src/cloudhsm/setup.py`	Bumps extension version.
`src/cloudhsm/README.md`	Lists all supported SKUs.
`src/cloudhsm/HISTORY.rst`	Documents API and SKU additions.
`src/cloudhsm/azext_cloudhsm/tests/latest/recordings/test_create_list_and_get_cloudHsm.yaml`	Updates cluster request API versions.
`src/cloudhsm/azext_cloudhsm/tests/latest/recordings/test_backup_restore.yaml`	Updates backup and restore API versions.
`src/cloudhsm/azext_cloudhsm/azext_metadata.json`	Raises minimum CLI version.
`src/cloudhsm/azext_cloudhsm/aaz/latest/cloudhsm/restore/_start.py`	Updates API and preview status.
`src/cloudhsm/azext_cloudhsm/aaz/latest/cloudhsm/restore/_show.py`	Updates unregistered status command API.
`src/cloudhsm/azext_cloudhsm/aaz/latest/cloudhsm/restore/__cmd_group.py`	Marks restore group as preview.
`src/cloudhsm/azext_cloudhsm/aaz/latest/cloudhsm/backup/_start.py`	Updates API and preview status.
`src/cloudhsm/azext_cloudhsm/aaz/latest/cloudhsm/backup/_show.py`	Updates unregistered status command API.
`src/cloudhsm/azext_cloudhsm/aaz/latest/cloudhsm/backup/__cmd_group.py`	Marks backup group as preview.
`src/cloudhsm/azext_cloudhsm/aaz/latest/cloudhsm/_update.py`	Updates API and preview status.
`src/cloudhsm/azext_cloudhsm/aaz/latest/cloudhsm/_show.py`	Updates API and preview status.
`src/cloudhsm/azext_cloudhsm/aaz/latest/cloudhsm/_list.py`	Updates both listing APIs and preview status.
`src/cloudhsm/azext_cloudhsm/aaz/latest/cloudhsm/_delete.py`	Updates API and preview status.
`src/cloudhsm/azext_cloudhsm/aaz/latest/cloudhsm/_create.py`	Adds v2 SKUs and updates API and preview status.
`src/cloudhsm/azext_cloudhsm/aaz/latest/cloudhsm/__cmd_group.py`	Marks CloudHSM group as preview.

_{Review effort: Balanced}

x-engineering-agent · 2026-10-20T17:23:00Z

X Engineering Agent Report

Review — Comments

neerjagangwar

Upstream CI completed without failures; the recording/SKU regression evidence below remains insufficient.

P2 — Updated recordings do not validate the new API/SKUs.

Paths below are relative to src/cloudhsm/azext_cloudhsm/.

aaz/latest/cloudhsm/_create.py:121,206,249–252 accepts five v2 SKUs and maps --sku to request sku.name using 2025-12-01-preview. However, tests/latest/test_cloudhsm.py:23–60 only exercises/asserts Standard_B1. Both tests/latest/recordings/test_create_list_and_get_cloudHsm.yaml:25 and tests/latest/recordings/test_backup_restore.yaml:22 equal their base versions after API-string replacement alone; their responses remain June 2025 exchanges. Playback cannot establish new-API service compatibility or v2 request/response/output behavior.

Add request/output assertions for all five v2 SKUs. Re-record the two named scenarios against the preview API, including a v2 create/show/list round trip and backup/restore terminal-output assertions, then rerun their playback tests.

Test validation

Agent live test: Not run; this is a review-only PR. Check author-provided test evidence and upstream CI separately.
Regression coverage: Not applicable to the changed files.
Semantic coverage gap: The changed API/SKU behavior lacks the evidence described above; no linked-issue coverage claim applies.

Risk assessment — 49/100 · Medium

The Medium rating is driven by public CLI behavior, dependency or supply chain, generated output.

Change scope: 18 changed files, 125 changed lines (+73 / -52), including 13 production files.
Affected components: cloudhsm
Risk drivers: public CLI behavior (+18); dependency or supply chain (+18); generated output (+12)
Regression evidence: Changed regression tests are included, reducing risk.
Confidence: High because changed-line patches were available for every production file.
Required review: Owning-squad review is required for cloudhsm before merge.

Posted by x-engineering-agent (Reviewer)

neerjagangwar mentioned this pull request Oct 19, 2026

[cloudhsm] Add 2025-12-01-preview models with v2 SKUs Azure/aaz#1133

Open

x-engineering-agent Bot added this to the November 2026 (2026-11-03) milestone Oct 19, 2026

neerjagangwar marked this pull request as ready for review October 20, 2026 13:18

Copilot AI balanced review requested due to automatic review settings October 20, 2026 13:18

Copilot started reviewing on behalf of neerjagangwar October 20, 2026 13:19

View session

Copilot AI reviewed Oct 20, 2026

View reviewed changes

Sean Morrissey (seanmorrissey98) approved these changes Oct 20, 2026

View reviewed changes

Nicola Camillucci (ncamillucci) approved these changes Oct 20, 2026

View reviewed changes

emmeliaAra approved these changes Oct 20, 2026

View reviewed changes

Teresa Ritorto (teresaritorto) added the Request X Engineering Agent Ask the agent to triage this issue or review this PR label Oct 20, 2026

x-engineering-agent Bot added the X Engineering Agent Reviewed Agent reviewed this PR label Oct 20, 2026

Navigation Menu

Repository navigation

[cloudhsm] Support API 2025-12-01-preview and v2 SKUs - #10488

[cloudhsm] Support API 2025-12-01-preview and v2 SKUs#10488
neerjagangwar wants to merge 1 commit into
Azure:mainfrom
neerjagangwar:cloudhsm-2025-12-01-preview

neerjagangwar commented Oct 19, 2026 •

edited

Loading

Uh oh!

azure-pipelines Bot commented Oct 19, 2026

Uh oh!

Aditya Pujara (a0x1ab) commented Oct 19, 2026

Uh oh!

azure-pipelines Bot commented Oct 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

x-engineering-agent Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

neerjagangwar commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 PR Validation — ⚠️ Review suggested

Related command

Description

Testing

General Guidelines

About Extension Publish

Uh oh!

azure-pipelines Bot commented Oct 19, 2026

Uh oh!

Aditya Pujara (a0x1ab) commented Oct 19, 2026

Uh oh!

azure-pipelines Bot commented Oct 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

x-engineering-agent Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

X Engineering Agent Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

neerjagangwar commented Oct 19, 2026 •

edited

Loading

x-engineering-agent Bot commented Oct 20, 2026 •

edited

Loading