Repository navigation
[edgeoperator]: Adding ALDO SystemConfiguration az cli extensions (preview) - #10480
kleyvaortega wants to merge 5 commits into
Conversation
|
Thank you for your contribution kleyvaortega! We will review the pull request and get back to you soon. |
|
Please fix CI issues |
There was a problem hiding this comment.
🟢 Approval recommended
The changes are focused, match the reviewed REST contract, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
Adds preview SystemConfiguration support to edgeoperator under the existing az aldo namespace.
Changes:
- Adds singleton configuration retrieval and full replacement using the active cloud’s ARM endpoint.
- Adds unit tests and sanitized GET and validation-error recordings.
- Documents command usage and updates the extension to
1.0.0b3.
| File | Description |
|---|---|
| src/edgeoperator/setup.py | Updates version and package description. |
| src/edgeoperator/README.rst | Documents commands and PUT requirements. |
| src/edgeoperator/HISTORY.rst | Records the new release. |
| src/edgeoperator/azext_edgeoperator/tests/latest/test_system_configuration_scenario.py | Adds recorded scenarios and sanitization. |
| src/edgeoperator/azext_edgeoperator/tests/latest/test_custom.py | Tests URLs and request payloads. |
| src/edgeoperator/azext_edgeoperator/tests/latest/recordings/test_system_configuration_show.yaml | Records successful retrieval. |
| src/edgeoperator/azext_edgeoperator/tests/latest/recordings/test_system_configuration_create_missing_fields.yaml | Records required-field validation errors. |
| src/edgeoperator/azext_edgeoperator/custom.py | Implements GET and PUT operations. |
| src/edgeoperator/azext_edgeoperator/commands.py | Registers show and create commands. |
| src/edgeoperator/azext_edgeoperator/_params.py | Defines writable configuration arguments. |
| src/edgeoperator/azext_edgeoperator/_help.py | Adds command descriptions and examples. |
Review effort: Balanced
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
X Engineering Agent ReportReview — Comments No confirmed semantic findings. Reviewed singleton GET/PUT routing, four-field serialization, cloud endpoint handling, command help and 1.0.0b3 release metadata. Author unit tests check request mappings; scenario recordings cover GET 200 and missing-field PUT 400, not successful replacement. Upstream CI reports no failures; runtime behavior was not independently exercised. Test validation
Risk assessment — 37/100 · MediumThe Medium rating is driven by public CLI behavior, dependency or supply chain.
Posted by x-engineering-agent (Reviewer) |
There was a problem hiding this comment.
kleyvaortega This recording processor seems unnecessary. The existing scenario test mechanism already sanitises sensitive values. Once recorded the recording will be set to the 2026-06-01-preview api, it shouldn't be necessary to clamp it down pre-emptively.
self.check should be used to assert the response body has not changed shape.
Please refer to https://github.com/Azure/azure-cli/blob/dev/doc/authoring_tests.md#automating-tests-for-azure-cli for guidelines on authoring tests.
The associated test_system_configuration_create_missing_fields.yaml and test_system_configuration_show.yaml appear to have failed, please fix them. These commands can be sufficiently tested using create -> show as the lifecycle of the scenario
There was a problem hiding this comment.
kleyvaortega Ready for human review. See the X Engineering Agent Report.
🤖 PR Validation —⚠️ Review suggested
Summary
Add SystemConfiguration support to the
edgeoperatorextension under the existingaz aldonamespace.az aldo system-configuration showto retrieve the active singleton configuration.az aldo system-configuration createto create or fully replace it using PUT.2026-06-01-previewand the active cloud's ARM endpoint.1.0.0b3.Validation
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aldo system-configuration show
az aldo system-configuration create
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.