Repository navigation
[agentfabric] Add Agent Fabric CLI extension - #10370
Open
Kshitija Murudi (kmurudi) wants to merge 21 commits into
Open
Kshitija Murudi (kmurudi) wants to merge 21 commits into
Kshitija Murudi (kmurudi) wants to merge 21 commits into
Conversation
|
Hi Kshitija Murudi (@kmurudi), |
Collaborator
|
agentfabric |
This was referenced Sep 21, 2026
Member
|
it is not a good practice to modify two moudles in one pr, let's split them. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add or carry over the Agent Fabric help recording required by the test scenarios.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This PR replaces the Agent Mesh source with the generated Agent Fabric extension while preserving src/index.json.
Changes:
- Adds Agent Fabric, member, and policy-group CRUD/wait commands.
- Updates packaging, metadata, documentation, tests, and service mapping.
- Removes obsolete Agent Mesh source.
- Critical review blocker (1 vote): Agent Fabric help tests require a missing
test_agentfabric_command_help.yamlrecording at lines 158 and 172.
| File | Summary |
|---|---|
src/service_name.json |
Updates service mapping for Agent Fabric. |
src/agentmesh/README.md |
Removes obsolete documentation. |
src/agentmesh/HISTORY.rst |
Removes obsolete release history. |
src/agentmesh/azext_agentmesh/tests/latest/test_agentmesh.py |
Removes obsolete tests. |
src/agentmesh/azext_agentmesh/tests/latest/recordings/test_agentmesh_command_help.yaml |
Removes the Agent Mesh help recording; an Agent Fabric replacement is required. |
src/agentmesh/azext_agentmesh/aaz/latest/agentmesh/fabric/member/__cmd_group.py |
Removes the obsolete command group. |
src/agentmesh/azext_agentmesh/aaz/latest/agentmesh/__init__.py |
Removes the obsolete generated initializer. |
src/agentfabric/setup.py |
Defines Agent Fabric package metadata. |
src/agentfabric/setup.cfg |
Adds package configuration. |
src/agentfabric/README.md |
Documents Agent Fabric commands and resource hierarchy. |
src/agentfabric/linter_exclusions.yml |
Updates command exclusions. |
src/agentfabric/HISTORY.rst |
Adds Agent Fabric release history. |
src/agentfabric/azext_agentfabric/tests/latest/test_agentfabric.py |
Adds validation tests; help-surface scenarios lack the required recording at lines 158 and 172. |
src/agentfabric/azext_agentfabric/tests/latest/__init__.py |
Initializes the latest test package. |
src/agentfabric/azext_agentfabric/tests/__init__.py |
Initializes the test package. |
src/agentfabric/azext_agentfabric/custom.py |
Adds the custom command module. |
src/agentfabric/azext_agentfabric/commands.py |
Adds the command loader. |
src/agentfabric/azext_agentfabric/azext_metadata.json |
Configures preview status and minimum CLI version. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/policy_group/_wait.py |
Adds policy-group wait operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/policy_group/_update.py |
Adds policy-group update operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/policy_group/_show.py |
Adds policy-group show operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/policy_group/_list.py |
Adds policy-group list operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/policy_group/_delete.py |
Adds policy-group delete operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/policy_group/_create.py |
Adds policy-group create operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/policy_group/__init__.py |
Registers policy-group commands. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/policy_group/__cmd_group.py |
Registers the policy-group command group. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/member/_wait.py |
Adds member wait operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/member/_update.py |
Adds member update operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/member/_show.py |
Adds member show operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/member/_list.py |
Adds member list operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/member/_delete.py |
Adds member delete operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/member/_create.py |
Adds member create operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/member/__init__.py |
Registers member commands. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/member/__cmd_group.py |
Registers the member command group. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/_wait.py |
Adds Agent Fabric wait operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/_update.py |
Adds Agent Fabric update operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/_show.py |
Adds Agent Fabric show operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/_list.py |
Adds Agent Fabric list operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/_delete.py |
Adds Agent Fabric delete operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/_create.py |
Adds Agent Fabric create operation. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/__init__.py |
Registers root commands. |
src/agentfabric/azext_agentfabric/aaz/latest/agentfabric/__cmd_group.py |
Registers the root command group. |
src/agentfabric/azext_agentfabric/aaz/latest/__init__.py |
Initializes the latest API package. |
src/agentfabric/azext_agentfabric/aaz/__init__.py |
Initializes the generated AAZ package. |
src/agentfabric/azext_agentfabric/_params.py |
Adds argument loading. |
src/agentfabric/azext_agentfabric/_help.py |
Adds extension help loading. |
src/agentfabric/azext_agentfabric/__init__.py |
Registers the Agent Fabric command loader. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Kshitija Murudi (kmurudi)
marked this pull request as draft
September 21, 2026 04:04
Kshitija Murudi (kmurudi)
changed the title
Contributor
Author
|
Agreed. This PR is now draft and is being rewritten to add only the new |
Kshitija Murudi (kmurudi)
force-pushed
the
kmurudi-add-agent-fabric
branch
from
September 21, 2026 04:10
2298a04 to
1258833
Compare
This was referenced Sep 21, 2026
Kshitija Murudi (kmurudi)
force-pushed
the
kmurudi-add-agent-fabric
branch
from
September 22, 2026 17:03
1258833 to
ee3f9c3
Compare
Kshitija Murudi (kmurudi)
marked this pull request as ready for review
September 22, 2026 17:04
Kshitija Murudi (kmurudi)
marked this pull request as draft
September 22, 2026 17:26
Kshitija Murudi (kmurudi)
marked this pull request as ready for review
September 22, 2026 19:04
Kshitija Murudi (kmurudi)
marked this pull request as draft
September 23, 2026 00:02
Kshitija Murudi (kmurudi)
force-pushed
the
kmurudi-add-agent-fabric
branch
from
October 16, 2026 06:09
ac48673 to
4998b77
Compare
Kshitija Murudi (kmurudi)
marked this pull request as ready for review
October 16, 2026 06:42
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Teresa Ritorto (teresaritorto)
added
the
Request X Engineering Agent
X Engineering Agent ReportReview — Comments No significant issues found in the reviewed changes. Upstream CI passed; live service behavior remains unverified, and no Agent live tests were run. Test validation
Risk assessment — 100/100 · CriticalThe Critical rating is driven by security-sensitive behavior, public CLI behavior, dependency or supply chain and 2 additional signal(s).
Posted by x-engineering-agent (Reviewer) |
![x-engineering-agent[bot]](https://avatars.githubusercontent.com/in/4205534?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
x-engineering-agent
Bot
added
X Engineering Agent Reviewed
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Contributor
|
Record public Central US EUAP Fabric, Member, Policy Group, and egress singleton operations. Preserve explicit skipped scenarios for ClusterConnectionInformationUnavailable and ResourceReadFailed service blockers, with ordered disposable-resource cleanup and signed operation URL scrubbing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Document managed Entra authentication prerequisite in custom attach help, remove the AKS scenario skip, and replay genuine successful enrollment calls. Keep Kubernetes workload operations separate and redact signed AKS polling URL parameters. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Replace the unconditional skip with the testsdk live_only marker so offline playback stays deterministic while live runs expose the outstanding ResourceReadFailed endpoint failure. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use the recorded Container Service API explicitly for the AKS prerequisite and cleanup, independent of the core CLI default. Preserve all real recordings and Agent Fabric request matching, and cover the pin with a regression test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
| subscription_id=subscription_id, api_version="2026-06-01" | ||
| ) | ||
|
|
||
| def _exercise_aks_lifecycle(self, cleanup): |
Contributor
There was a problem hiding this comment.
Kshitija Murudi (@kmurudi) There are a number of 404s found in the test_agentfabric_aks_lifecycle.yaml recording. Please ensure the full life cycle is functional
Contributor
Author
There was a problem hiding this comment.
Reviewed all 50 interactions in the AKS lifecycle recording. Exactly three 404s remain, and each is an expected absence check:
- Interaction 5:
aks createfirst GETs its new managed-cluster name to verify that it does not exist before PUT. - Interaction 32:
agentfabric aks wait --deletedGETs the association after detach; ResourceNotFound confirms deletion. - Interaction 50:
agentfabric wait --deletedGETs the Fabric after delete; ResourceNotFound confirms deletion.
The positive attach/show/list/Standard-to-Premium update/wait/detach operations in that genuine live trace succeeded, and the recorded lifecycle replays successfully. Converting the expected absence/deletion responses to 200 would invalidate those checks, so the AKS cassette remains unchanged. No new live AKS provisioning/lifecycle run was performed for this read-only recording update.
3b3aa3b6c documents the distinction and adds a fresh successful egress LIST/SHOW recording, removing its old live-only gap. The complete playback/unit suite passed: 22 passed, zero skipped, 3 subtests passed; style and linter passed.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
JaysonTaiMicrosoft
added
the
Request X Engineering Agent
JaysonTaiMicrosoft
modified the milestones:
October 2026 (2026-10-06),
November 2026 (2026-11-03)
There was a problem hiding this comment.
Kshitija Murudi (@kmurudi) Ready for human review. See the X Engineering Agent Report.
x-engineering-agent
Bot
removed
the
Request X Engineering Agent
Keep member show, list, and wait; resource providers handle member mutations. Replace the member lifecycle scenario and recording with read-only coverage for an existing member. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9395a3e0-0d18-414d-b40d-c8fd7f90ac67
Enable ordinary playback for read-only collection and singleton responses recorded from the live preview service. Document existing-Fabric recording prerequisites and the AKS lifecycle's expected absence/deletion checks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the preview Agent Fabric extension generated from the final public
Microsoft.NetworkSecurity2026-10-07-previewcontract onRPSaaSMaster.Authoritative generation sources
a52c4fc4ac8cd197d38a1072704853f485cafb6c.specification/networksecurity/resource-manager/Microsoft.NetworkSecurity/agentFabric/preview/2026-10-07-preview/agentFabric.json.6de5cd31bbf92e418b5946074bcb3591ca8d30b538521cdf30cd6c24fa35d508.5ca157eba98d8f3b846e77df92d4944ebf060555.Customer-facing commands
az agentfabric: create/show/list/update/delete/wait.az agentfabric member: Agent Fabric Sandbox member create/show/list/update/delete/wait.az agentfabric aks: attach/show/list/update/detach/wait over Cluster Association ARM resources.az agentfabric egress-trust-bundle: read-only show/list foregressTrustBundles/default.az agentfabric policy-group: independent peer-resource create/show/list/update/delete/wait.Final contract behavior
-p/--inspection-profile/--content-inspection-profile. The API key remains write-only and is absent from GET/list/wait/LRO output. Root PATCH remains tags and identity only.AgentFabricSandboxworkloads. ACI/AKS Member examples, arguments, request serialization, response discriminators, descriptions, and tests are not present anywhere in the generated Member command folder.blueprintId.resourceGuidandmemberGuidretain the final UUID response typing where applicable. Member PATCH remains tags plus FQDN; workload is immutable after creation.servicePort,protocol, andtargetPort; the removed singleportfield is not exposed.aks updateperforms GET-before-PATCH to preserve the immutable target resource ID required for linked authorization. Gateway IP uses-i/--gateway-ip/--workload-cluster-gateway-ipand remains PATCH-only, intentionally absent from attach/show/list output.clusterResourceIdcontract without inventing another REST operation or discriminator. This is separate from the sandbox-only Member command group.The extension remains preview
1.0.0b1with minimum CLI2.75.0.src/index.jsonand allsrc/agentmeshsource/metadata have no PR diff; published Agent Mesh index withdrawal/source removal is handled separately by #10369/#10371. No private namespace patches, deployment changes, CODEOWNERS changes, or invented documentation URL are included.This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az agentfabricGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.Validation
Latest sandbox-only Member command delta:
python -m pytest src\agentfabric\azext_agentfabric\tests\latest\test_agentfabric.py -q: 15 passed, 5 subtests passed.workload: null, and ACI/AKS content remains only in the intentional AKS Cluster Association lifecycle. Redundant subscription-wide Fabric and Policy Group list interactions that captured unrelated live ACI resources were removed.python -m flake8 src\agentfabric\azext_agentfabric src\agentfabric\setup.py: passed.python scripts\ci\test_index.py -q: OK, 9 tests run, 2 skipped.compileallandgit diff --check: passed.agentfabric-1.0.0b1-py3-none-any.whl, 95,040 bytes, SHA-2560cc88294260c032b39f84fef4e64e74c7a70d5e9d1829fb47027c7c2b4f3ac8f.member,member create/show/list/update/delete/wait; no help surface contains ACI/AKS references.inspect.getargspecremoval and unconfigured azdev/VCR authentication), before Agent Fabric assertions execute.Existing full-extension validation retained from the preceding PR head:
azdev style agentfabric: passed (pylint and flake8).azdev linter agentfabric --include-whl-extensions --min-severity medium --ci-exclusions: passed, zero violations with the extension's source exclusions loaded.src/index.jsonandsrc/agentmesh: no PR diff.